From 877ee07fa443bbd2c1da49d26e3b5596ed0378fc Mon Sep 17 00:00:00 2001
From: "William S. Moses" <gh@wsmoses.com>
Date: Thu, 11 Sep 2025 20:50:30 -0500
Subject: [PATCH 1/2] Fix lda on blas

---
 enzyme/Enzyme/BlasDerivatives.td | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/enzyme/Enzyme/BlasDerivatives.td b/enzyme/Enzyme/BlasDerivatives.td
index 36f1a366ccb7..a8e460c7b25b 100644
--- a/enzyme/Enzyme/BlasDerivatives.td
+++ b/enzyme/Enzyme/BlasDerivatives.td
@@ -801,8 +801,8 @@ def potrf: CallBlasPattern<(Op $layout, $uplo, $n, $A, $lda, $info),
                       (CopyLowerToUpper<""> $layout, $uplo, (Shadow $A), $n),
                       
                       // Actual Math
-                      (BlasCall<"trsm"> $layout, Char<"L">, $uplo, (uplo_to_normal $uplo), Char<"N">, $n, $n, Constant<"1.0">, $A, $lda, (Shadow $A)),
-                      (BlasCall<"trsm"> $layout, Char<"R">, $uplo, (uplo_to_trans $uplo), Char<"N">, $n, $n, Constant<"1.0">, $A, $lda, (Shadow $A)),
+                      (BlasCall<"trsm"> $layout, Char<"L">, $uplo, (uplo_to_normal $uplo), Char<"N">, $n, $n, Constant<"1.0">, $A, (ld $A, Char<"N">, $lda, $n, $n), (Shadow $A)),
+                      (BlasCall<"trsm"> $layout, Char<"R">, $uplo, (uplo_to_trans $uplo), Char<"N">, $n, $n, Constant<"1.0">, $A, (ld $A, Char<"N">, $lda, $n, $n), (Shadow $A)),
                       (BlasCall<"scal"> $n, Constant<"0.5">, (First (Shadow $A)), (Add $lda, ConstantInt<1>)),
 
                      (Seq<["tmp", "vector", "n"], [], 1>
@@ -814,7 +814,7 @@ def potrf: CallBlasPattern<(Op $layout, $uplo, $n, $A, $lda, $info),
                         (BlasCall<"copy"> $n, use<"tmp">, ConstantInt<1>, (First (Shadow $A)), (Add $lda, ConstantInt<1>)),
 
                         // More math
-                        (BlasCall<"trmm"> $layout, (uplo_to_side $uplo), $uplo, Char<"N">, Char<"N">, $n, $n, Constant<"1.0">, $A, $lda, (Shadow $A)),    
+                        (BlasCall<"trmm"> $layout, (uplo_to_side $uplo), $uplo, Char<"N">, Char<"N">, $n, $n, Constant<"1.0">, $A, (ld $A, Char<"N">, $lda, $n, $n), (Shadow $A)),    
                         // Restore the flipped side, but saving our computed diagonal
                         (BlasCall<"copy"> $n, (First (Shadow $A)), (Add $lda, ConstantInt<1>), use<"tmp">, ConstantInt<1>),
                         (BlasCall<"lacpy"> $layout, (flip_uplo $uplo), $n, $n, use<"tri">, $n, (Shadow $A)),

From 1bc3a7490311ca8b0ee6e24bed6c00e6407348c6 Mon Sep 17 00:00:00 2001
From: "William S. Moses" <gh@wsmoses.com>
Date: Thu, 11 Sep 2025 20:53:08 -0500
Subject: [PATCH 2/2] run real tests

---
 enzyme/test/Integration/ReverseMode/blas.cpp | 2 --
 1 file changed, 2 deletions(-)

diff --git a/enzyme/test/Integration/ReverseMode/blas.cpp b/enzyme/test/Integration/ReverseMode/blas.cpp
index 838899614672..6ddbdb7a5fdd 100644
--- a/enzyme/test/Integration/ReverseMode/blas.cpp
+++ b/enzyme/test/Integration/ReverseMode/blas.cpp
@@ -2205,7 +2205,6 @@ static void symmTests() {
 }
 
 int main() {
-    /*
   dotTests();
 
   nrm2Tests();
@@ -2227,7 +2226,6 @@ int main() {
   trtrsTests();
   
   symmTests();
-  */
 
   symvTests();
 }