Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need support for Tagging users and to style it inside TextInput #1825

Open
ridsashabbir opened this issue Jan 9, 2025 · 8 comments
Open
Assignees
Labels
enhancement New feature or request

Comments

@ridsashabbir
Copy link

so this is something like Instagram's comment section, where you can reply to other users' comments on a post, but it will use a different styling for it, also you can tag other users in that comment section using the @ sign and style it accordingly

image

image

@ridsashabbir ridsashabbir added the enhancement New feature or request label Jan 9, 2025
@kmahmood74 kmahmood74 assigned snehmehta and unassigned kmahmood74 Jan 9, 2025
@github-project-automation github-project-automation bot moved this to Backlog in Ensemble Jan 9, 2025
@kmahmood74 kmahmood74 moved this from Backlog to Ready for Work in Ensemble Jan 9, 2025
@amin-nas amin-nas assigned mehsaandev and unassigned snehmehta Jan 27, 2025
@mehsaandev
Copy link
Contributor

mehsaandev commented Jan 30, 2025

Proposed EDL for Mentionable Input:

 TagInput:
      id: inputId
      styles:
           mentionStyle: # text Style of default mention tag starting with @ sign
               color: red # for example if my input is "Hi, how are you @ehsaan" in this @ehsaan will be colored red 
      triggers:
        - character: '#'
           tagStyle: 
               color: blue # for example if my input is "This is a #beutiful place" in this @beutiful will be colored blue 
      tags:
        - id: 1
          key: ehsaan
          label: Muhammad Ehsaan
          image: # profile picture
          labelWidget: # custom widget for tags list item in case you want to add custom view for the list
        - id: 2
          key: ridsa
          label: Ridsa Shabbir
          image: # profile picture
          labelWidget: # custom widget for tags list item
        - id: 3
          key: nouman
          label: Nouman Butt
          image: # profile picture
          labelWidget: # custom widget for tags list item

If we don't use labelWidget and use our default tag label, it will be displayed like this:

Image

Any suggestions
CC: @ridsashabbir @amin-nas @sharjeelyunus

@kmahmood74
Copy link
Collaborator

you are not mentioning, you are tagging, fix the name.

@mehsaandev
Copy link
Contributor

you are not mentioning, you are tagging, fix the name.

Updated to TagInput

@sharjeelyunus
Copy link
Member

sharjeelyunus commented Jan 30, 2025

tags should be here, and for each item defining a custom labelWidget will make it more complex
there should be a tagSheet or something like that, which accepts a widget, and users can define there own sheet and use any widget to item template the users. trigger should open that sheet

@amin-nas
Copy link
Contributor

@mehsaandev we would need to be able to style the tag selection box. I also assume existing input styling can be set on this.

TagInput:
      styles:
           tegStyle: # text Style of default mention tag starting with @ sign
           tagSelectionStyle:

@mehsaandev
Copy link
Contributor

@mehsaandev we would need to be able to style the tag selection box. I also assume existing input styling can be set on this.

TagInput:
styles:
tegStyle: # text Style of default mention tag starting with @ sign
tagSelectionStyle:

Got it
Yes we can do existing input styling to this as well

@mehsaandev
Copy link
Contributor

tags should be here, and for each item defining a custom labelWidget will make it more complex there should be a tagSheet or something like that, which accepts a widget, and users can define there own sheet and use any widget to item template the users. trigger should open that sheet

I think we can directly support itemTemplate to this because in any case I am showing a sheet/modal which will have the list of all the items. If I support that tagSheet separately then it'll not necessarily enforce the user to provide a list because tagSheet can accept any widget but this requires a list.
What do you say? @sharjeelyunus

@sharjeelyunus
Copy link
Member

sharjeelyunus commented Jan 30, 2025

yes, that works as well, also we need action as well in this input, e.g onTrigger so we can call an api to search the users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Ready for Work
Development

No branches or pull requests

6 participants