From e8222d7af5bc64df9a1dae7084d706993c81706d Mon Sep 17 00:00:00 2001 From: osher-sade Date: Mon, 15 Apr 2019 18:06:26 +0300 Subject: [PATCH 1/5] fix: removed the moment-timezone dependency --- package-lock.json | 85 +++++++++++----------- package.json | 5 +- src/configurations/logger-configuration.ts | 1 - src/timezone-formatter.ts | 11 --- src/winston-logger.ts | 76 +++++++++---------- test/winston-logger.test.ts | 6 -- 6 files changed, 80 insertions(+), 104 deletions(-) delete mode 100644 src/timezone-formatter.ts diff --git a/package-lock.json b/package-lock.json index d548b4a..1a5bec6 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1103,9 +1103,9 @@ } }, "@octokit/rest": { - "version": "16.23.4", - "resolved": "https://registry.npmjs.org/@octokit/rest/-/rest-16.23.4.tgz", - "integrity": "sha512-fQuYQ0vgNLkzeN0KEsqN0aS6EPzcuaePT5M5cE5qnKayaxFwRIQOMhNR/rTmEqo/zDK/20ZAcHsgLKodSsJtww==", + "version": "16.24.1", + "resolved": "https://registry.npmjs.org/@octokit/rest/-/rest-16.24.1.tgz", + "integrity": "sha512-V2GVL+cfuwNTcZ9qtBMOR9pIftWo1AiZIiGvWNmTcIQG5mkj83ZXC+g3w5g0cVXt7Hi+mSOrD2bZ7HJOuouUNg==", "dev": true, "requires": { "@octokit/request": "3.0.0", @@ -1360,14 +1360,6 @@ "integrity": "sha512-tHq6qdbT9U1IRSGf14CL0pUlULksvY9OZ+5eEgl1N7t+OA3tGvNpxJCzuKQlsNgCVwbAs670L1vcVQi8j9HjnA==", "dev": true }, - "@types/moment-timezone": { - "version": "0.5.12", - "resolved": "https://registry.npmjs.org/@types/moment-timezone/-/moment-timezone-0.5.12.tgz", - "integrity": "sha512-hnHH2+Efg2vExr/dSz+IX860nSiyk9Sk4pJF2EmS11lRpMcNXeB4KBW5xcgw2QPsb9amTXdsVNEe5IoJXiT0uw==", - "requires": { - "moment": ">=2.14.0" - } - }, "@types/node": { "version": "10.12.12", "resolved": "https://registry.npmjs.org/@types/node/-/node-10.12.12.tgz", @@ -2090,9 +2082,9 @@ "dev": true }, "bottleneck": { - "version": "2.17.1", - "resolved": "https://registry.npmjs.org/bottleneck/-/bottleneck-2.17.1.tgz", - "integrity": "sha512-ARJKJRNq6+W7BBYZnkqA1F4+HDclht7QyRJl2haAVtD7xBTG8Prpy6huO+canGLUxZaRrek8U/0NjTvoXACsaQ==", + "version": "2.18.0", + "resolved": "https://registry.npmjs.org/bottleneck/-/bottleneck-2.18.0.tgz", + "integrity": "sha512-U1xiBRaokw4yEguzikOl0VrnZp6uekjpmfrh6rKtr1D+/jFjYCL6J83ZXlGtlBDwVdTmJJ+4Lg5FpB3xmLSiyA==", "dev": true }, "boxen": { @@ -3119,7 +3111,7 @@ }, "enabled": { "version": "1.0.2", - "resolved": "https://registry.npmjs.org/enabled/-/enabled-1.0.2.tgz", + "resolved": "http://registry.npmjs.org/enabled/-/enabled-1.0.2.tgz", "integrity": "sha1-ll9lE9LC0cX0ZStkouM5ZGf8L5M=", "requires": { "env-variable": "0.0.x" @@ -3775,7 +3767,8 @@ "ansi-regex": { "version": "2.1.1", "bundled": true, - "dev": true + "dev": true, + "optional": true }, "aproba": { "version": "1.2.0", @@ -3796,12 +3789,14 @@ "balanced-match": { "version": "1.0.0", "bundled": true, - "dev": true + "dev": true, + "optional": true }, "brace-expansion": { "version": "1.1.11", "bundled": true, "dev": true, + "optional": true, "requires": { "balanced-match": "^1.0.0", "concat-map": "0.0.1" @@ -3816,17 +3811,20 @@ "code-point-at": { "version": "1.1.0", "bundled": true, - "dev": true + "dev": true, + "optional": true }, "concat-map": { "version": "0.0.1", "bundled": true, - "dev": true + "dev": true, + "optional": true }, "console-control-strings": { "version": "1.1.0", "bundled": true, - "dev": true + "dev": true, + "optional": true }, "core-util-is": { "version": "1.0.2", @@ -3943,7 +3941,8 @@ "inherits": { "version": "2.0.3", "bundled": true, - "dev": true + "dev": true, + "optional": true }, "ini": { "version": "1.3.5", @@ -3955,6 +3954,7 @@ "version": "1.0.0", "bundled": true, "dev": true, + "optional": true, "requires": { "number-is-nan": "^1.0.0" } @@ -3969,6 +3969,7 @@ "version": "3.0.4", "bundled": true, "dev": true, + "optional": true, "requires": { "brace-expansion": "^1.1.7" } @@ -3976,12 +3977,14 @@ "minimist": { "version": "0.0.8", "bundled": true, - "dev": true + "dev": true, + "optional": true }, "minipass": { "version": "2.3.5", "bundled": true, "dev": true, + "optional": true, "requires": { "safe-buffer": "^5.1.2", "yallist": "^3.0.0" @@ -4000,6 +4003,7 @@ "version": "0.5.1", "bundled": true, "dev": true, + "optional": true, "requires": { "minimist": "0.0.8" } @@ -4080,7 +4084,8 @@ "number-is-nan": { "version": "1.0.1", "bundled": true, - "dev": true + "dev": true, + "optional": true }, "object-assign": { "version": "4.1.1", @@ -4092,6 +4097,7 @@ "version": "1.4.0", "bundled": true, "dev": true, + "optional": true, "requires": { "wrappy": "1" } @@ -4177,7 +4183,8 @@ "safe-buffer": { "version": "5.1.2", "bundled": true, - "dev": true + "dev": true, + "optional": true }, "safer-buffer": { "version": "2.1.2", @@ -4213,6 +4220,7 @@ "version": "1.0.2", "bundled": true, "dev": true, + "optional": true, "requires": { "code-point-at": "^1.0.0", "is-fullwidth-code-point": "^1.0.0", @@ -4232,6 +4240,7 @@ "version": "3.0.1", "bundled": true, "dev": true, + "optional": true, "requires": { "ansi-regex": "^2.0.0" } @@ -4275,12 +4284,14 @@ "wrappy": { "version": "1.0.2", "bundled": true, - "dev": true + "dev": true, + "optional": true }, "yallist": { "version": "3.0.3", "bundled": true, - "dev": true + "dev": true, + "optional": true } } }, @@ -4613,9 +4624,9 @@ "dev": true }, "hook-std": { - "version": "1.2.0", - "resolved": "https://registry.npmjs.org/hook-std/-/hook-std-1.2.0.tgz", - "integrity": "sha512-yntre2dbOAjgQ5yoRykyON0D9T96BfshR8IuiL/r3celeHD8I/76w4qo8m3z99houR4Z678jakV3uXrQdSvW/w==", + "version": "2.0.0", + "resolved": "https://registry.npmjs.org/hook-std/-/hook-std-2.0.0.tgz", + "integrity": "sha512-zZ6T5WcuBMIUVh49iPQS9t977t7C0l7OtHrpeMb5uk48JdflRX0NSFvCekfYNmGQETnLq9W/isMyHl69kxGi8g==", "dev": true }, "hosted-git-info": { @@ -7140,14 +7151,6 @@ "resolved": "https://registry.npmjs.org/moment/-/moment-2.24.0.tgz", "integrity": "sha512-bV7f+6l2QigeBBZSM/6yTNq4P2fNpSWj/0e7jQcy87A8e7o2nAfP/34/2ky5Vw4B9S446EtIhodAzkFCcR4dQg==" }, - "moment-timezone": { - "version": "0.5.23", - "resolved": "https://registry.npmjs.org/moment-timezone/-/moment-timezone-0.5.23.tgz", - "integrity": "sha512-WHFH85DkCfiNMDX5D3X7hpNH3/PUhjTGcD0U1SgfBGZxJ3qUmJh5FdvaFjcClxOvB3rzdfj4oRffbI38jEnC1w==", - "requires": { - "moment": ">= 2.9.0" - } - }, "ms": { "version": "2.1.1", "resolved": "https://registry.npmjs.org/ms/-/ms-2.1.1.tgz", @@ -11521,9 +11524,9 @@ "dev": true }, "semantic-release": { - "version": "15.13.8", - "resolved": "https://registry.npmjs.org/semantic-release/-/semantic-release-15.13.8.tgz", - "integrity": "sha512-92c5Kfz+qfMIE4gAxhzUg/LY1uoW4R4fSsMqNpXx8YNpYsrTL+bY0AI1zYxPjSKfXO22Ld55jjPja62Dl5KgCg==", + "version": "15.13.9", + "resolved": "https://registry.npmjs.org/semantic-release/-/semantic-release-15.13.9.tgz", + "integrity": "sha512-EKm23KsIAfq1P9dMx8y7YmMHvWZRvmEEUE7z9FXQy2iY1k4jeeRYJTab1aykbYJ1Vj2p9mtkPo59Yi7YVsPUdw==", "dev": true, "requires": { "@semantic-release/commit-analyzer": "^6.1.0", @@ -11540,7 +11543,7 @@ "find-versions": "^3.0.0", "get-stream": "^5.0.0", "git-log-parser": "^1.2.0", - "hook-std": "^1.1.0", + "hook-std": "^2.0.0", "hosted-git-info": "^2.7.1", "lodash": "^4.17.4", "marked": "^0.6.0", diff --git a/package.json b/package.json index 292198e..a07688e 100644 --- a/package.json +++ b/package.json @@ -15,7 +15,6 @@ "clean": "shx rm -rf node_modules/ dist/ docs/", "typedoc": "typedoc --out ./docs --mode modules --tsconfig ./tsconfig.json ./src/", "posttypedoc": "shx cp .nojekyll docs/.nojekyll", - "buildDependents": "npm i && tsc && npm link", "prepare": "npm run lint:fix && npm run build", "lint": "npm run tslint-check && tslint -p .", "lint:fix": "npm run tslint-check && tslint -p . --fix", @@ -68,8 +67,6 @@ "@types/serialize-error": "^2.1.0", "@types/winston": "^2.4.4", "clean-deep": "^3.0.2", - "moment-timezone": "^0.5.23", - "@types/moment-timezone": "^0.5.12", "serialize-error": "^3.0.0", "winston": "^3.2.1", "winston-daily-rotate-file": "^3.8.0", @@ -88,7 +85,7 @@ "pre-commit": "^1.2.2", "prettier": "^1.16.4", "rimraf": "^2.6.3", - "semantic-release": "^15.13.3", + "semantic-release": "^15.13.9", "shx": "^0.3.2", "travis-deploy-once": "^5.0.11", "ts-jest": "^23.10.5", diff --git a/src/configurations/logger-configuration.ts b/src/configurations/logger-configuration.ts index baaf663..9af2e99 100644 --- a/src/configurations/logger-configuration.ts +++ b/src/configurations/logger-configuration.ts @@ -9,6 +9,5 @@ export interface LoggerConfiguration { writeFullMessageToConsole?: boolean; logFilePath?: string; dailyRotateFileConfiguration?: DailyRotateFileConfiguration; - timezone?: string; customTransports?: Transport[]; } diff --git a/src/timezone-formatter.ts b/src/timezone-formatter.ts deleted file mode 100644 index 373b272..0000000 --- a/src/timezone-formatter.ts +++ /dev/null @@ -1,11 +0,0 @@ -import * as moment from 'moment-timezone'; -import * as winston from 'winston'; - -export const appendTimestamp = (timezone: string) => { - return winston.format((info: any) => { - info.timestamp = moment() - .tz(timezone) - .format(); - return info; - }); -}; diff --git a/src/winston-logger.ts b/src/winston-logger.ts index 8bebff3..5723559 100644 --- a/src/winston-logger.ts +++ b/src/winston-logger.ts @@ -2,44 +2,39 @@ import * as winston from 'winston'; import * as DailyRotateFile from 'winston-daily-rotate-file'; import { LogstashTransport } from 'winston-logstash-transport'; import { LoggerConfiguration } from './configurations/logger-configuration'; -import { appendTimestamp } from './timezone-formatter'; -const consoleFullFormat = (timezone: string) => { - return winston.format.combine( - appendTimestamp(timezone)(), - winston.format.align(), - winston.format.printf(info => { - const { timestamp, level, message, ...args } = info; - const ts = timestamp.slice(0, 19).replace('T', ' '); - return `${ts} [${level}]: ${message} ${ - Object.keys(args).length ? `\n${JSON.stringify(args, null, 2)}` : '' - }`; - }), - ); -}; +const dateFormat: string = 'DD-MM-YYYY HH:mm:ss'; -const consoleShortFormat = (timezone: string) => { - return winston.format.combine( - appendTimestamp(timezone)(), - winston.format.align(), - winston.format.printf(info => { - const { timestamp, level, message, throwable } = info; - const ts = timestamp.slice(0, 19).replace('T', ' '); - return `${ts} [${level}]: ${message} ${ - throwable ? `\n${JSON.stringify(throwable, null, 2)}` : '' - }`; - }), - ); -}; +const consoleFullFormat = winston.format.combine( + winston.format.timestamp({ format: dateFormat }), + winston.format.align(), + winston.format.printf(info => { + const { timestamp, level, message, ...args } = info; + const ts = timestamp.slice(0, 19).replace('T', ' '); + return `${ts} [${level}]: ${message} ${ + Object.keys(args).length ? `\n${JSON.stringify(args, null, 2)}` : '' + }`; + }), +); -const logstashFormat = (timezone: string) => { - return winston.format.combine( - appendTimestamp(timezone)(), - winston.format.printf(info => { - return JSON.stringify(info); - }), - ); -}; +const consoleShortFormat = winston.format.combine( + winston.format.timestamp({ format: dateFormat }), + winston.format.align(), + winston.format.printf(info => { + const { timestamp, level, message, throwable } = info; + const ts = timestamp.slice(0, 19).replace('T', ' '); + return `${ts} [${level}]: ${message} ${ + throwable ? `\n${JSON.stringify(throwable, null, 2)}` : '' + }`; + }), +); + +const logstashFormat = winston.format.combine( + winston.format.timestamp({ format: dateFormat }), + winston.format.printf(info => { + return JSON.stringify(info); + }), +); const customLevels = { levels: { @@ -61,7 +56,6 @@ const customLevels = { }; export const createLogger = (loggerConfiguration: LoggerConfiguration) => { - const timezone = loggerConfiguration.timezone || 'Israel'; const logger = winston.createLogger({ level: loggerConfiguration.loggerLevel, levels: customLevels.levels, @@ -75,7 +69,7 @@ export const createLogger = (loggerConfiguration: LoggerConfiguration) => { new LogstashTransport({ host: logstashConfiguration.logstashHost, port: logstashConfiguration.logstashPort, - format: logstashFormat(timezone), + format: logstashFormat, }), ); }); @@ -88,8 +82,8 @@ export const createLogger = (loggerConfiguration: LoggerConfiguration) => { format: winston.format.combine( winston.format.colorize(), loggerConfiguration.writeFullMessageToConsole - ? consoleFullFormat(timezone) - : consoleShortFormat(timezone), + ? consoleFullFormat + : consoleShortFormat, ), }), ); @@ -99,7 +93,7 @@ export const createLogger = (loggerConfiguration: LoggerConfiguration) => { const dailyFileConf = loggerConfiguration.dailyRotateFileConfiguration; logger.add( new DailyRotateFile({ - format: logstashFormat(timezone), + format: logstashFormat, datePattern: 'DD-MM-YYYY', filename: `${dailyFileConf.directoryPath}${ dailyFileConf.fileNamePrefix @@ -112,7 +106,7 @@ export const createLogger = (loggerConfiguration: LoggerConfiguration) => { } else if (loggerConfiguration.logFilePath) { logger.add( new winston.transports.File({ - format: logstashFormat(timezone), + format: logstashFormat, filename: loggerConfiguration.logFilePath, }), ); diff --git a/test/winston-logger.test.ts b/test/winston-logger.test.ts index cc9ee2f..05b1518 100644 --- a/test/winston-logger.test.ts +++ b/test/winston-logger.test.ts @@ -34,12 +34,6 @@ jest.mock('winston-logstash-transport', () => { return { LogstashTransport: jest.fn() }; }); -jest.mock('../src/timezone-formatter.ts', () => { - return { - appendTimestamp: jest.fn().mockImplementation(() => jest.fn()), - }; -}); - describe('winston-logger tests', () => { const loggerLevel: string = 'info'; const logstashHost: string = 'test'; From bd12f5fec5646e779c7beee158e7348c07956c05 Mon Sep 17 00:00:00 2001 From: osher-sade Date: Mon, 15 Apr 2019 18:12:58 +0300 Subject: [PATCH 2/5] refactor: renamed const --- src/winston-logger.ts | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/winston-logger.ts b/src/winston-logger.ts index 5723559..513e92d 100644 --- a/src/winston-logger.ts +++ b/src/winston-logger.ts @@ -3,10 +3,10 @@ import * as DailyRotateFile from 'winston-daily-rotate-file'; import { LogstashTransport } from 'winston-logstash-transport'; import { LoggerConfiguration } from './configurations/logger-configuration'; -const dateFormat: string = 'DD-MM-YYYY HH:mm:ss'; +const timestampFormat: string = 'DD-MM-YYYY HH:mm:ss'; const consoleFullFormat = winston.format.combine( - winston.format.timestamp({ format: dateFormat }), + winston.format.timestamp({ format: timestampFormat }), winston.format.align(), winston.format.printf(info => { const { timestamp, level, message, ...args } = info; @@ -18,7 +18,7 @@ const consoleFullFormat = winston.format.combine( ); const consoleShortFormat = winston.format.combine( - winston.format.timestamp({ format: dateFormat }), + winston.format.timestamp({ format: timestampFormat }), winston.format.align(), winston.format.printf(info => { const { timestamp, level, message, throwable } = info; @@ -30,7 +30,7 @@ const consoleShortFormat = winston.format.combine( ); const logstashFormat = winston.format.combine( - winston.format.timestamp({ format: dateFormat }), + winston.format.timestamp({ format: timestampFormat }), winston.format.printf(info => { return JSON.stringify(info); }), From ad8c704fccaec368608879b7f8464a718d3482e5 Mon Sep 17 00:00:00 2001 From: osher-sade Date: Tue, 16 Apr 2019 10:54:46 +0300 Subject: [PATCH 3/5] refactor: removed .nojekyll --- .nojekyll | 0 1 file changed, 0 insertions(+), 0 deletions(-) delete mode 100644 .nojekyll diff --git a/.nojekyll b/.nojekyll deleted file mode 100644 index e69de29..0000000 From e3d5de8f16c3d1eea6903ef544b9c1e951dc317d Mon Sep 17 00:00:00 2001 From: osher-sade Date: Tue, 16 Apr 2019 11:14:58 +0300 Subject: [PATCH 4/5] refactor: renamed repositoryVersion to version --- README.md | 8 ++++---- src/entities/application-log-properties.ts | 2 +- src/polaris-logger.ts | 2 +- src/winston-logger.ts | 6 ++---- test/polaris-logger.test.ts | 14 +++++++------- 5 files changed, 15 insertions(+), 17 deletions(-) diff --git a/README.md b/README.md index 24bfbf7..3a63fd0 100644 --- a/README.md +++ b/README.md @@ -34,7 +34,7 @@ This interface represent the application configurable log properties. Those properties are: + systemId + systemName - + repositoryVersion + + version + environment + component @@ -53,7 +53,7 @@ import { ApplicationLogProperties, LoggerConfiguration, PolarisLogger } from '@e const appProps: ApplicationLogProperties = { id: 'p0laris-l0gs', name: 'polaris-logs', - repositoryVersion: 'v1', + version: 'v1', environment: 'environment', component: 'component', }; @@ -82,8 +82,8 @@ const logConf: LoggerConfiguration = { const logger = new PolarisLogger(appProps, logConf); -logger.fatal('fatal message'); -logger.error('error message'); +logger.fatal('fatal message', { elapsedTime: 500, eventKind: 'foo' }); +logger.error('error message', { elapsedTime: 15000, throwable: new Error('oops') }); logger.warn('warn message'); logger.info('info message'); logger.debug('debug message'); diff --git a/src/entities/application-log-properties.ts b/src/entities/application-log-properties.ts index 8f0ffc1..8fadf67 100644 --- a/src/entities/application-log-properties.ts +++ b/src/entities/application-log-properties.ts @@ -1,7 +1,7 @@ export interface ApplicationLogProperties { id: string; name: string; - repositoryVersion: string; + version: string; environment: string; component: string; } diff --git a/src/polaris-logger.ts b/src/polaris-logger.ts index 30db7b8..74e20c7 100644 --- a/src/polaris-logger.ts +++ b/src/polaris-logger.ts @@ -16,7 +16,7 @@ export class PolarisLogger { eventKindDescription: { systemId: applicationProperties.id, }, - repositoryVersion: applicationProperties.repositoryVersion, + version: applicationProperties.version, environment: applicationProperties.environment, component: applicationProperties.component, }; diff --git a/src/winston-logger.ts b/src/winston-logger.ts index 513e92d..960f330 100644 --- a/src/winston-logger.ts +++ b/src/winston-logger.ts @@ -10,8 +10,7 @@ const consoleFullFormat = winston.format.combine( winston.format.align(), winston.format.printf(info => { const { timestamp, level, message, ...args } = info; - const ts = timestamp.slice(0, 19).replace('T', ' '); - return `${ts} [${level}]: ${message} ${ + return `${timestamp} [${level}]: ${message} ${ Object.keys(args).length ? `\n${JSON.stringify(args, null, 2)}` : '' }`; }), @@ -22,8 +21,7 @@ const consoleShortFormat = winston.format.combine( winston.format.align(), winston.format.printf(info => { const { timestamp, level, message, throwable } = info; - const ts = timestamp.slice(0, 19).replace('T', ' '); - return `${ts} [${level}]: ${message} ${ + return `${timestamp} [${level}]: ${message} ${ throwable ? `\n${JSON.stringify(throwable, null, 2)}` : '' }`; }), diff --git a/test/polaris-logger.test.ts b/test/polaris-logger.test.ts index 05d5b9b..13966aa 100644 --- a/test/polaris-logger.test.ts +++ b/test/polaris-logger.test.ts @@ -24,7 +24,7 @@ describe('polaris-logger tests', () => { const appProps: ApplicationLogProperties = { id: 'p0laris-l0gs', name: 'polaris-logs', - repositoryVersion: 'v1', + version: 'v1', environment: 'environment', component: 'component', }; @@ -46,7 +46,7 @@ describe('polaris-logger tests', () => { message, component: appProps.component, environment: appProps.environment, - repositoryVersion: appProps.repositoryVersion, + version: appProps.version, eventKindDescription: { systemId: appProps.id }, system: { id: appProps.id, name: appProps.name }, }); @@ -59,7 +59,7 @@ describe('polaris-logger tests', () => { message, component: appProps.component, environment: appProps.environment, - repositoryVersion: appProps.repositoryVersion, + version: appProps.version, eventKindDescription: { systemId: appProps.id }, system: { id: appProps.id, name: appProps.name }, }); @@ -72,7 +72,7 @@ describe('polaris-logger tests', () => { message, component: appProps.component, environment: appProps.environment, - repositoryVersion: appProps.repositoryVersion, + version: appProps.version, eventKindDescription: { systemId: appProps.id }, system: { id: appProps.id, name: appProps.name }, }); @@ -85,7 +85,7 @@ describe('polaris-logger tests', () => { message, component: appProps.component, environment: appProps.environment, - repositoryVersion: appProps.repositoryVersion, + version: appProps.version, eventKindDescription: { systemId: appProps.id }, system: { id: appProps.id, name: appProps.name }, }); @@ -98,7 +98,7 @@ describe('polaris-logger tests', () => { message, component: appProps.component, environment: appProps.environment, - repositoryVersion: appProps.repositoryVersion, + version: appProps.version, eventKindDescription: { systemId: appProps.id }, system: { id: appProps.id, name: appProps.name }, }); @@ -111,7 +111,7 @@ describe('polaris-logger tests', () => { message, component: appProps.component, environment: appProps.environment, - repositoryVersion: appProps.repositoryVersion, + version: appProps.version, eventKindDescription: { systemId: appProps.id }, system: { id: appProps.id, name: appProps.name }, }); From ee6551be215333eb2a26e65ac71f0348a0dae885 Mon Sep 17 00:00:00 2001 From: osher-sade Date: Tue, 16 Apr 2019 11:33:41 +0300 Subject: [PATCH 5/5] docs: updated README --- README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index 3a63fd0..46ac6cc 100644 --- a/README.md +++ b/README.md @@ -32,8 +32,8 @@ days. This interface represent the application configurable log properties. Those properties are: - + systemId - + systemName + + id + + name + version + environment + component