Commit a57deca
committed
Remove rules_scala prebuilt protoc toolchain
Using Bazel 9 with `protobuf` v34.0 automatically enables the prebuilt
`protoc` toolchain from `@protobuf`. There's no need to keep using the
`rules_scala` toolchain, which breaks with `protobuf` v34.0 because
`rules_scala` v7.2.4 doesn't support it. See
bazel-contrib/rules_scala#1820.
Also contains `MODULE.bazel.lock` updates generated by the
`--lockfile_mode=refresh` flag.
`bazel build //...` and `bazel test //...` both succeed. However, this
still causes a `protoc` rebuild, thanks to a `@grpc-java` dependency:
```txt
$ bazel query 'somepath(//..., @protobuf//:protoc)'
//java/com/engflow/notificationqueue/demoserver:server_java_grpc_proto
@grpc-java//compiler:java_grpc_library_toolchain
@protobuf//:protoc
```
`@grpc-java//compiler:java_grpc_library_toolchain` is a
`java_grpc_library` target. That rule's `_protoc` attribute is hardcoded
to `Label("@com_google_protobuf//:protoc")`:
- https://github.com/grpc/grpc-java/blob/v1.79.0/compiler/BUILD.bazel#L44-L49
- https://github.com/grpc/grpc-java/blob/v1.79.0/java_grpc_library.bzl#L441 parent dc943fe commit a57deca
2 files changed
+104
-43
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
45 | 45 | | |
46 | 46 | | |
47 | 47 | | |
48 | | - | |
49 | | - | |
50 | 48 | | |
51 | 49 | | |
52 | 50 | | |
| |||
167 | 165 | | |
168 | 166 | | |
169 | 167 | | |
170 | | - | |
171 | | - | |
172 | | - | |
173 | | - | |
174 | | - | |
175 | | - | |
176 | | - | |
177 | 168 | | |
0 commit comments