-
Notifications
You must be signed in to change notification settings - Fork 1
Doesn't seem to work well with monorepos #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Yep, we could find some solution for that :) |
Seems to be weird today for me that the same path |
👋 This is a real issue. I am able to bypass this by putting following nohoist option into root {
"name": "monorepo",
"private": true,
"workspaces": {
"packages": [
"frontend",
"monorepo-components"
],
"nohoist": [
"**/ember-cli-deploy-netlify-cli",
"**/netlify",
"**/ember-cli-deploy-netlify-cli/**",
"**/netlify/**"
]
},
} Then I will get: ❯ ls -alh frontend/node_modules/.bin/netlify
lrwxr-xr-x 1 michal staff 22B 18 Jul 20:55 frontend/node_modules/.bin/netlify -> ../netlify-cli/bin/run Documenting for future travelers. But it would be better if the users of this library would not have to do such hacks. |
For a project folder structure like:
The deploy plugin is expecting the node_modules to be under
host-app
folder due to this line. Perhaps, workspaces/monorepos create thenode_modules
at the root of the repo.The plugin should detect if it is run from a workspace configured ember app and if so, not expect it to have the
node_modules
but the root one.One possible solution I could think of is to use
npx
based commands for this same LoC and prevent the need for adevDependency
ofnetlify
.The text was updated successfully, but these errors were encountered: