Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write unit tests for Rails app #21

Merged
merged 19 commits into from
Oct 27, 2022
Merged

Write unit tests for Rails app #21

merged 19 commits into from
Oct 27, 2022

Conversation

ElsonOtake
Copy link
Owner

@ElsonOtake ElsonOtake commented Oct 26, 2022 •
edited
Loading

  • Unit tests for models created;
  • Unit tests for controllers created.

Screen Shot 2022-10-25 at 9 59 57 PM

@ElsonOtake ElsonOtake linked an issue Oct 26, 2022 that may be closed by this pull request
[4pts] Write unit tests for Rails app. #5
Closed
GiuseppeTG
GiuseppeTG approved these changes Oct 27, 2022
View reviewed changes
Copy link
Collaborator

@GiuseppeTG GiuseppeTG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ElsonOtake @AntonioHincapie 👋 ,

Your project is complete! There is nothing else to say other than... it's time to merge it 🥇 :
Congratulations! 🎉

Alt Text

Highlights

✅ Very complete testing

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

@ElsonOtake ElsonOtake merged commit ef5637d into dev Oct 27, 2022
@ElsonOtake ElsonOtake deleted the Unit_tests branch October 27, 2022 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GiuseppeTG GiuseppeTG GiuseppeTG approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[4pts] Write unit tests for Rails app.
3 participants
@ElsonOtake @GiuseppeTG @AntonioHincapie