Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create authorization and authentication rules #20

Merged
merged 35 commits into from
Oct 24, 2022
Merged

Create authorization and authentication rules #20

merged 35 commits into from
Oct 24, 2022

Conversation

ElsonOtake
Copy link
Owner

@ElsonOtake ElsonOtake commented Oct 24, 2022 •
edited
Loading

  • Install Devise gem;
  • Install CanCanCan gem;
  • Config authorization rules;
  • Config authentication rules.

image

AntonioHincapie and others added 30 commits October 20, 2022 16:43
@AntonioHincapie
Install CanCanCan and Devise gem
d75f702
@AntonioHincapie
Add basic config to devise
8c8c3e2
@AntonioHincapie
Run devise migration
2c24ceb
@AntonioHincapie
Add basic config of CanCanCan
8877aee
@ElsonOtake
Update commands
1d4f12f
@ElsonOtake
Install Rack cors
0214762
@ElsonOtake
Merge branch 'api_endpoints' into authorization_authentication
f224146 
Install rack cors# the commit.
@ElsonOtake
Install jwt
30d1cff
@ElsonOtake
Create new route and create user action
8450ce6
@ElsonOtake
Set up login
d1d49a4
@ElsonOtake
Update users crud
1642b05
@ElsonOtake
Update request authorization
0f9ff4a
@ElsonOtake
Fix linter error
cda0030
@ElsonOtake
Update columns booking table
a191209
@ElsonOtake
Update columns vehicles table
a14ee76
@ElsonOtake
Update seed to new columns
e66b9b4
@ElsonOtake
Disable require authentication
c04e2db
@ElsonOtake
Set up heroku deployment
6baac29
@ElsonOtake
Update line break
9c19a90
@ElsonOtake
Install active model serializers
2dd3560
@ElsonOtake
Set up serializers
eb0cc51
@ElsonOtake
Rename galery to gallery
7093c02
@ElsonOtake
Add return for delete and update
f531d32
@ElsonOtake
Update login by username instead of email
407769b
@ElsonOtake
Update request authentication
b52c3f5
@ElsonOtake
Update users column name to unique index
e73bee9
@ElsonOtake
Add current_user method
673038e
@ElsonOtake
Add load and authorize resource
2c50455
@ElsonOtake
Add abilities
79093a9
@ElsonOtake
Update token return with name, role, and id
02dde93
@AntonioHincapie AntonioHincapie linked an issue Oct 24, 2022 that may be closed by this pull request
[4pts] Create authorization and authentication rules. #3
Closed
GiuseppeTG
GiuseppeTG approved these changes Oct 24, 2022
View reviewed changes
Copy link
Collaborator

@GiuseppeTG GiuseppeTG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ElsonOtake 👋 ,

Your project is complete! There is nothing else to say other than... it's time to merge it 🥇 :
Congratulations! 🎉

Alt Text

Highlights

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

@ElsonOtake ElsonOtake merged commit f7fddd8 into dev Oct 24, 2022
@ElsonOtake ElsonOtake deleted the authorization_authentication branch October 24, 2022 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GiuseppeTG GiuseppeTG GiuseppeTG approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[4pts] Create authorization and authentication rules.
3 participants
@ElsonOtake @GiuseppeTG @AntonioHincapie