Add delete item #22
Merged
Add delete item #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
AntonioHincapie
commented
Oct 26, 2022
AntonioHincapie
commented
- Create a function that allows to the users click the "Delete" button, when this happens the selected item is marked as removed and does not show on the main list anymore.
- Create a function that allows to the user click the "Add" button, when this happens the new item is created and should render on the home page.
- Responsive design.
GiuseppeTG
approved these changes
Oct 26, 2022
There was a problem hiding this comment.
Hi @AntonioHincapie 👋 ,
Your project is complete! There is nothing else to say other than... it's time to merge it 🥇 :
Congratulations! 🎉
Highlights
✅ Nice job
Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.