From c14273ee213ff008a64b7042f03bce5559363454 Mon Sep 17 00:00:00 2001
From: oklopfer <104327997+oklopfer@users.noreply.github.com>
Date: Fri, 29 Mar 2024 21:52:43 -0400
Subject: [PATCH] do the checks for constraints (#10)

Co-authored-by: ook37 <oren+12345@taumoda.com>
---
 misc/scripts/checks.sh | 83 ++++++++++++++----------------------------
 1 file changed, 28 insertions(+), 55 deletions(-)

diff --git a/misc/scripts/checks.sh b/misc/scripts/checks.sh
index 04d1ebdb6..d18e2ae0c 100755
--- a/misc/scripts/checks.sh
+++ b/misc/scripts/checks.sh
@@ -210,45 +210,35 @@ function lint_maintainer() {
     return 0
 }
 
-function lint_makedepends() {
-    local ret=0 makedepend idx=0
-    if [[ -n ${makedepends[*]} ]]; then
-        for makedepend in "${makedepends[@]}"; do
-            if [[ -z ${makedepend} ]]; then
-                fancy_message error "'makedepends' index '${idx}' cannot be empty"
-                ret=1
-            fi
-            ((idx++))
-        done
-    fi
-    return "${ret}"
+function lint_pipe_check() {
+    perl -ne 'exit 1 unless /^(?:[^\s|:]+(?::[^\s|:]+)?\s\|\s)+[^\s|:]+(?::[^\s|:]+)?(?::\s[^|:]+)?(?<!\s)$/' <<< "$1"
+    return $?
 }
 
-function lint_depends() {
-    local ret=0 depend idx=0
-    if [[ -n ${depends[*]} ]]; then
-        for depend in "${depends[@]}"; do
-            if [[ -z ${depend} ]]; then
-                fancy_message error "'depends' index '${idx}' cannot be empty"
-                ret=1
-            fi
-            ((idx++))
-        done
-    fi
-    return "${ret}"
-}
-
-function lint_pacdeps() {
-    local ret=0 pacdep idx=0
-    if [[ -n ${pacdeps[*]} ]]; then
-        for pacdep in "${pacdeps[@]}"; do
-            if [[ -z ${pacdep} ]]; then
-                fancy_message error "'pacdeps' index '${idx}' cannot be empty"
-                ret=1
-            fi
-            ((idx++))
-        done
-    fi
+function lint_deps() {
+    local dep_type dep_array ret=0 dep idx
+    for dep_type in "depends" "makedepends" "optdepends" "pacdeps"; do
+        idx=0
+        local -n dep_array="${dep_type}"
+        if [[ -n ${dep_array[*]} ]]; then
+            for dep in "${dep_array[@]}"; do
+                if [[ -z ${dep} ]]; then
+                    fancy_message error "'${dep_type}' index '${idx}' cannot be empty"
+                    ret=1
+                elif [[ ${dep_type} == "optdepends" && ${dep} != *": "* ]] \
+                || [[ ${dep} == *"|"* ]] \
+				&& [[ ${dep_type} == "pacdeps" ]] \
+                || ! lint_pipe_check "${dep}"; then
+                    fancy_message error "'${dep_type}' index '${idx}' is not formatted correctly"
+                    ret=1
+                fi
+                ((idx++))
+            done
+        fi
+        if ((ret == 1)); then
+            break
+        fi
+    done
     return "${ret}"
 }
 
@@ -285,23 +275,6 @@ function lint_ppa() {
     return "${ret}"
 }
 
-function lint_optdepends() {
-    local ret=0 optdepend idx=0
-    if [[ -n ${optdepends[*]} ]]; then
-        for optdepend in "${optdepends[@]}"; do
-            if [[ -z ${optdepend} ]]; then
-                fancy_message error "'optdepends' index '${idx}' cannot be empty"
-                ret=1
-            elif [[ $optdepend != *": "* ]]; then
-                fancy_message error "'optdepends' index '${idx}' is not formatted correctly"
-                ret=1
-            fi
-            ((idx++))
-        done
-    fi
-    return "${ret}"
-}
-
 function lint_conflicts() {
     local ret=0 conflict idx=0
     if [[ -n ${conflicts[*]} ]]; then
@@ -554,7 +527,7 @@ function lint_priority() {
 }
 
 function checks() {
-    local ret=0 check linting_checks=(lint_pkgname lint_gives lint_pkgrel lint_epoch lint_version lint_source lint_pkgdesc lint_maintainer lint_makedepends lint_depends lint_pacdeps lint_ppa lint_optdepends lint_conflicts lint_breaks lint_replaces lint_hash lint_patch lint_provides lint_incompatible lint_arch lint_mask lint_priority)
+    local ret=0 check linting_checks=(lint_pkgname lint_gives lint_pkgrel lint_epoch lint_version lint_source lint_pkgdesc lint_maintainer lint_deps lint_ppa lint_conflicts lint_breaks lint_replaces lint_hash lint_patch lint_provides lint_incompatible lint_arch lint_mask lint_priority)
     for check in "${linting_checks[@]}"; do
         "${check}" || ret=1
     done