Skip to content

Commit dd7a4de

Browse files
committed
Test fewer test parallelism values and reps
- Test `--test-threads` operands of 1 to 4, rather than 1 to 7. - Do 7 reps instead of 16. In addition to the 1000x repetition in `checkout.rs` of the writes_through_symlinks_are_prevented_even_if_overwriting_is_allowed test case, which in practice always surfaces GitoxideLabs#2006 on CI on macOS and Windows, the `test-ext4-casefold` job as it currenly stands seems sufficient to test whether a possible future solution would fix the bug on GNU/Linux. This looks like about the minmum amount we should reasonably verify still fails (in some jobs) immediately before a GitoxideLabs#2006 fix, while no longer failing *any* jobs afterwards. But the `test-ext4-casefold` jobs are still much more than would be wanted on the main branch. Assuming the cause of the failures is the same on all systems, and the solution neither explicitly nor implicitly operates differently across systems (when comparing how it works when the filesystem is case-insensitive, that is), it may be enough on CI to regression test only macOS and Windows for GitoxideLabs#2006. Thus, this also adds a TODO comment atop the `test-ext4-casefold` definition reminding that it should not be kept, or not in full.
1 parent c3f156f commit dd7a4de

File tree

1 file changed

+6
-8
lines changed

1 file changed

+6
-8
lines changed

.github/workflows/ci.yml

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -185,20 +185,18 @@ jobs:
185185
- name: Check that tracked archives are up to date
186186
run: git diff --exit-code # If this fails, the fix is usually to commit a regenerated archive.
187187

188+
# TODO(integration): Remove all or at least most test-ext4-casefold jobs prior to merging #2008.
188189
test-ext4-casefold:
189190
strategy:
190191
matrix:
191192
# `--test-threads` operand
192193
parallel-tests:
193-
- 1 # Never seems to fail, which makes sense.
194-
- 2
195-
- 3 # Never seems to fail, which does NOT make sense.
196-
- 4
197-
- 5
198-
- 6
199-
- 7
194+
- 1 # Never fails.
195+
- 2 # Usually fails.
196+
- 3 # Almost never fails, somehow!
197+
- 4 # Usually fails.
200198
# Duplicate jobs
201-
rep: ['A', 'B', 'C', 'D', 'E', 'F', 'G', 'H', 'I', 'J', 'K', 'L', 'M', 'N', O, P]
199+
rep: [A, B, C, D, E, F, G]
202200
fail-fast: false
203201

204202
runs-on: ubuntu-latest

0 commit comments

Comments
 (0)