Skip to content

Perform basic conventional checks in Git pre-commit hook #7765

Open
@s373nZ

Description

@s373nZ

Following from this conversation on Discord, @cdecker writes:

Sure, there are plenty of pre-commit plugins for that type of lint. A quick search surfaced https://github.com/compilerla/conventional-pre-commit for example.
I also wonder if we should remove some of our custom tooling in favor of better maintained conventional tools (shellcheck run, JSON schema format check, JSON schema validation, check that files were regenerated when needed, etc. currently there are loads of make targets that just check something in ci, when really we want to enforce them for new code. The upside would be that we check during commit, but the same rules can just be double checked in ci from the same config.

This issue represents the beginning of an initiative to improve standardization and offload some of the CI checks into the developer workflow, starting with the following brainstorm:

  • shellcheck run
  • JSON schema format check
  • Check regenerated files
  • lint commit messages and validate against accepted conventions
  • Python linting

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions