Merge pull request #112 from EbenezerGH/cleanup-dependency-tree

pull out versions to seperate gradle file

Author: EbenezerGH

build.gradle

@@ -1,14 +1,15 @@
 // Top-level build file where you can add configuration options common to all sub-projects/modules.
 
 buildscript {
-    ext.kotlin_version = '1.2.30'
+    apply from: "${project.rootDir}/versions.gradle"
+
     repositories {
         google()
         jcenter()
     }
     dependencies {
-        classpath 'com.android.tools.build:gradle:3.0.1'
-        classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version"
+        classpath "com.android.tools.build:gradle:$project.android_gradle_version"
+        classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$project.kotlin_plugin_version"
 
         // NOTE: Do not place your application dependencies here; they belong
         // in the individual module build.gradle files

etherscanapi/build.gradle

@@ -2,22 +2,25 @@ apply plugin: 'com.android.library'
 apply plugin: 'kotlin-android'
 
 android {
-    compileSdkVersion 26
+    compileSdkVersion project.compile_sdk_version
 
     defaultConfig {
-        minSdkVersion 14
-        targetSdkVersion 26
-        versionCode 1
-        versionName "1.0.0"
+        minSdkVersion project.min_sdk
+        targetSdkVersion project.target_sdk_version
+        versionCode project.version_code
+        versionName project.version_name
 
         testInstrumentationRunner "android.support.test.runner.AndroidJUnitRunner"
     }
 
     buildTypes {
         release {
-            minifyEnabled false
+            minifyEnabled true
             proguardFiles getDefaultProguardFile('proguard-android.txt'), 'proguard-rules.pro'
         }
+        debug {
+            minifyEnabled false
+        }
     }
 
 }
@@ -26,33 +29,25 @@ android {
 dependencies {
     implementation fileTree(include: ['*.jar'], dir: 'libs')
 
-    /**
-     Because RxAndroid releases are few and far between, it is recommended you also
-     explicitly depend on RxKotlin's latest version for bug fixes and new features.
-     */
-    implementation 'io.reactivex.rxjava2:rxandroid:2.0.1'
-    implementation 'io.reactivex.rxjava2:rxkotlin:2.2.0'
+    // kotlin
+    implementation "org.jetbrains.kotlin:kotlin-stdlib-jre7:$project.kotlin_version"
+
+    // rx
+    implementation "io.reactivex.rxjava2:rxkotlin:$project.reactivex_rxjava2_rxkotlin_version"
 
     // gson
-    implementation 'com.google.code.gson:gson:2.8.2'
+    implementation "com.google.code.gson:gson:$project.gson_version"
 
     // retrofit
-    implementation 'com.squareup.retrofit2:retrofit:2.4.0'
-    implementation 'com.squareup.retrofit2:converter-gson:2.4.0'
-    implementation 'com.squareup.retrofit2:adapter-rxjava2:2.4.0'
-
-    // kotlin
-    implementation "org.jetbrains.kotlin:kotlin-stdlib-jre7:$kotlin_version"
-
-    // timber
-    implementation 'com.jakewharton.timber:timber:4.7.0'
+    implementation "com.squareup.retrofit2:retrofit:$project.retrofit2_core_version"
+    implementation "com.squareup.retrofit2:converter-gson:$project.retrofit2_converter_gson_version"
+    implementation "com.squareup.retrofit2:adapter-rxjava2:$project.retrofit2_adapter_version"
 
     // tests
-    testImplementation 'junit:junit:4.12'
-    testImplementation 'org.mockito:mockito-core:2.17.0'
-    testImplementation 'com.squareup.okhttp3:mockwebserver:3.10.0'
-    testImplementation 'com.android.support.test:runner:1.0.1'
-    androidTestImplementation 'com.android.support.test.espresso:espresso-core:3.0.1'
+    testImplementation "junit:junit:$project.junit_version"
+    testImplementation "org.mockito:mockito-core:$project.mockito_core_version"
+    testImplementation "com.squareup.okhttp3:mockwebserver:$project.mockwebserver_version"
+    androidTestImplementation "com.android.support.test.espresso:espresso-core:$project.espresso_core_version"
 
     repositories {
         mavenCentral()

gradle/wrapper/gradle-wrapper.properties

@@ -1,6 +1,6 @@
-#Wed Apr 11 19:07:44 EDT 2018
+#Thu Jun 14 15:26:50 EDT 2018
 distributionBase=GRADLE_USER_HOME
 distributionPath=wrapper/dists
 zipStoreBase=GRADLE_USER_HOME
 zipStorePath=wrapper/dists
-distributionUrl=https\://services.gradle.org/distributions/gradle-4.1-all.zip
+distributionUrl=https\://services.gradle.org/distributions/gradle-4.4-all.zip

versions.gradle

@@ -0,0 +1,31 @@
+ext {
+    min_sdk = 15
+    target_sdk_version = 26
+    compile_sdk_version = 26
+    build_tools_version = "27.0.3"
+    version_code= 1
+    version_name = "1.0.0"
+
+
+    // plugins
+    android_gradle_version = "3.1.3"
+    kotlin_plugin_version = "1.2.30"
+
+
+    // libs
+    kotlin_version = "1.2.31"
+    gson_version = "2.8.2"
+    retrofit2_core_version = "2.4.0"
+    retrofit2_converter_gson_version = "2.4.0"
+    retrofit2_adapter_version = "2.4.0"
+    reactivex_rxjava2_rxkotlin_version = "2.2.0"
+
+
+    // testlibs
+    kluent_version = "1.34" // todo #111
+    espresso_core_version = "3.0.2"
+    junit_version = "4.12"
+    mockito_core_version = "2.18.3"
+    mockwebserver_version = "3.10.0"
+
+}