Skip to content

Commit 4937461

Browse files
Merge pull request #45 from EatSleepProgramRepeat/44-jars-produced-by-gradlew-build-cant-search
44-jars-produced-by-gradlew-build-cant-search
2 parents 9659b5b + 5302f37 commit 4937461

4 files changed

Lines changed: 17 additions & 6 deletions

File tree

build.gradle.kts

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,8 @@ file("src/main/resources/version.properties").takeIf { it.exists() }?.let {
1919
plugins {
2020
id("java")
2121
id("application")
22+
application
23+
id("com.github.johnrengelman.shadow") version "8.1.1"
2224
}
2325

2426
group = "org.example"
@@ -56,4 +58,9 @@ tasks.named<Jar>("jar") {
5658
"Main-Class" to "com.CDPrintable.Main"
5759
)
5860
}
59-
}
61+
}
62+
63+
tasks.withType<com.github.jengelman.gradle.plugins.shadow.tasks.ShadowJar> {
64+
archiveClassifier.set("all")
65+
mergeServiceFiles()
66+
}

src/main/java/com/CDPrintable/MusicBrainzResources/MusicBrainzArtist.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,8 @@
1010

1111
package com.CDPrintable.MusicBrainzResources;
1212

13+
import java.util.Locale;
14+
1315
public class MusicBrainzArtist {
1416
private String name;
1517
private String dateOrganized; // May only be present for groups
@@ -121,7 +123,9 @@ public void setBirthDate(String birthDate) {
121123
}
122124

123125
public String getCountry() {
124-
return country;
126+
if (country == null || country.equals("xw")) {return null;}
127+
Locale locale = new Locale.Builder().setRegion(country).build();
128+
return locale.getDisplayName();
125129
}
126130

127131
public void setCountry(String country) {

src/main/java/com/CDPrintable/MusicBrainzResources/MusicBrainzJSONReader.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -235,10 +235,6 @@ public MusicBrainzArtist[] getArtists() {
235235
}
236236

237237
String country = jsonHasAndIsNotNull(jsonObject, "country") ? jsonObject.get("country").getAsString() : null;
238-
if (country != null) {
239-
Locale locale = new Locale.Builder().setRegion(country).build();
240-
country = locale.getDisplayCountry();
241-
}
242238

243239
return new MusicBrainzArtist(name, organizedDate, birthDate, id, sortName, gender, type, disambiguation, lifeSpan, country);
244240
}, new MusicBrainzArtist[0]);

src/main/java/com/CDPrintable/WebRequest.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,10 +51,14 @@ public WebRequest(String url, String userAgent) {
5151
*/
5252
public String sendRequest() throws IOException, URISyntaxException {
5353
HttpURLConnection connection = (HttpURLConnection) new URI(url).toURL().openConnection();
54+
5455
connection.setRequestMethod("GET");
5556
connection.setRequestProperty("User-Agent", userAgent);
5657
connection.setRequestProperty("Accept", "application/json");
5758

59+
connection.setConnectTimeout(6000);
60+
connection.setReadTimeout(5000);
61+
5862
int responseCode = connection.getResponseCode();
5963
if (responseCode != HttpURLConnection.HTTP_OK) {
6064
throw new IOException("HTTP error code: " + responseCode);

0 commit comments

Comments
 (0)