Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When using a layout with SecondsFrame, Text is blinking when "Farbübergang" is activated #515

Open
Vrumfondel opened this issue Jan 16, 2025 · 2 comments
Labels
bug Something isn't working

Comments

@Vrumfondel
Copy link

Vrumfondel commented Jan 16, 2025

When using a layout with SecondsFrame and "Farbübergang" is enabled, for each tick of the SecondsFrame the displayed words are shortly blinking in the Foreground color before switched again to the correct "random" color.

These blinking effects is visible on all Display modes.
Might this be caused by the order of the calls in loop(), where transition->loop() is called before secondsFrame->loop(), while the latter one might call led.clear() on each change, and the inpact of transition is elimitated until the next call to loop()?

@dbambus
Copy link
Collaborator

dbambus commented Jan 17, 2025

Hey @Vrumfondel,

I tried to fix it some time ago, but must admit this could be complicated. I wanted to rework the transitions in order to get a full understanding of the problem.

But well. I thought I m almost the only one using a "Ambient Light" on the Clock, sooooo I moved it on my agenda a few times.

Cheers David

@dbambus dbambus added the bug Something isn't working label Jan 17, 2025
@Vrumfondel
Copy link
Author

One question to this issue:

After playing around a little, I removed " parametersChanged = true; " at the end of frameLogic() --> Issue gone.

Why would setting "parameterChanged" needed there anyways? I don't see how frameLogic() would even do this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants