Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for IKEA E2201 RODRET Dimmer. #689

Conversation

yarafie
Copy link
Contributor

@yarafie yarafie commented Feb 14, 2025

Thank you for taking the time to work on a Pull Request. Your contribution is really appreciated! 🎉
Please don't delete any part of the template, since keeping the provided structure will help maintainers to review your work more rapidly.

Sections marked as * are required and need to be filled in.

Proposed change*

IKEA E2201 RODRET Dimmer - Initial Release -
Added support for IKEA E2201 RODRET Dimmer.

Checklist*

  • [Y] I followed sections of the [Contribution Guidelines (https://github.com/yarafie/awesome-ha-blueprints/blob/main/CONTRIBUTING.md) relevant to changes I'm proposing.
  • [Y] I properly tested proposed changes on my system and confirm that they are working as expected.
  • [Y] I formatted files with Prettier using the command npm run format before submitting my Pull Request.

Copy link
Contributor

Hey @yarafie, thank you so much for your contribution! 🚀

🔄 We're currently running a few checks to make sure that everything is great with your contribution.
If further actions need to be performed before your contribution can be reviewed, additional guidance will be provided to you in the next comment.

Results are coming soon, stay tuned!

@yarafie
Copy link
Contributor Author

yarafie commented Feb 15, 2025

@EPMatt I've done some extreme modifications to the virtual double press take a look.
No need for a text helper.
Also, another modification, no need to preselect the integration type, its handled within the blueprint itself.

@EPMatt
Copy link
Owner

EPMatt commented Feb 16, 2025

Hi @yarafie,
thank you so much for your contribution! Reviewing this today. 🚀

@EPMatt
Copy link
Owner

EPMatt commented Feb 16, 2025

For anyone coming to this PR, here's the link to test the blueprint.

https://github.com/yarafie/awesome-ha-blueprints/blob/20250214-yarafie-ikea-rodret-e2201-new-controller/blueprints/controllers/ikea_e2201/ikea_e2201.yaml

Feel free to report your feedback here! 🔥

Copy link
Contributor

github-actions bot commented Feb 16, 2025

Hey @EPMatt, thank you so much for your contribution! 🚀

🔄 We're currently running a few checks to make sure that everything is great with your contribution.
If further actions need to be performed before your contribution can be reviewed, additional guidance will be provided to you in the next comment.

Results are coming soon, stay tuned!

Repository owner deleted a comment from github-actions bot Feb 16, 2025
Copy link
Contributor

Hey @EPMatt,

✅ Your contribution passed all the checks, awesome!
A maintainer will soon review your submission and provide additional feedback regarding your changes.

Thanks again for dedicating your precious time to this project. 🔥

@EPMatt EPMatt force-pushed the 20250214-yarafie-ikea-rodret-e2201-new-controller branch from f6fa28f to b481815 Compare February 16, 2025 23:15
Copy link
Contributor

Hey @EPMatt, thank you so much for your contribution! 🚀

🔄 We're currently running a few checks to make sure that everything is great with your contribution.
If further actions need to be performed before your contribution can be reviewed, additional guidance will be provided to you in the next comment.

Results are coming soon, stay tuned!

Copy link
Contributor

github-actions bot commented Feb 16, 2025

@EPMatt EPMatt force-pushed the 20250214-yarafie-ikea-rodret-e2201-new-controller branch 2 times, most recently from 8abf256 to c974b09 Compare February 16, 2025 23:30
Repository owner deleted a comment from github-actions bot Feb 16, 2025
Repository owner deleted a comment from github-actions bot Feb 16, 2025
Copy link
Contributor

github-actions bot commented Feb 16, 2025

Hey @EPMatt,

❌ It looks like there are some issues with your contribution. Don't worry, here's some additional information and guidance on how to solve them.

  • Your files are not properly formatted. Did you remember to run npm run format before submitting your changes?

Please fix reported issues, then submit your updates here. If you have any questions or doubts, you can always contact a project maintainer. :)

Thanks!

Copy link
Contributor

github-actions bot commented Feb 16, 2025

Hey @yarafie, thank you so much for your contribution! 🚀

🔄 We're currently running a few checks to make sure that everything is great with your contribution.
If further actions need to be performed before your contribution can be reviewed, additional guidance will be provided to you in the next comment.

Results are coming soon, stay tuned!

Copy link
Contributor

github-actions bot commented Feb 16, 2025

@Nicolai-
Copy link

Nicolai- commented Feb 17, 2025

@EPMatt I've done some extreme modifications to the virtual double press take a look. No need for a text helper. Also, another modification, no need to preselect the integration type, its handled within the blueprint itself.

Very nice!

@yarafie yarafie force-pushed the 20250214-yarafie-ikea-rodret-e2201-new-controller branch from 69c10c3 to 94df897 Compare February 20, 2025 06:11
@yarafie yarafie closed this Feb 20, 2025
@yarafie yarafie deleted the 20250214-yarafie-ikea-rodret-e2201-new-controller branch February 20, 2025 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Controller - Ikea RODRET E2201
3 participants