fix some calls to virtual methods in virtual class constructors (identified by clang-tidy)

Author: sophiapoirier

dfx-library/dfxplugin.cpp

@@ -45,7 +45,7 @@ This is our class for E-Z plugin-making and E-Z multiple-API support.
 
 #if defined(TARGET_API_VST) && TARGET_PLUGIN_HAS_GUI
 	#include "dfxguieditor.h"
-	extern AEffEditor* DFXGUI_NewEditorInstance(DfxPlugin* inEffectInstance);
+	[[nodiscard]] extern std::unique_ptr<DfxGuiEditor> DFXGUI_NewEditorInstance(DGEditorListenerInstance inEffectInstance);
 #endif
 
 #ifdef TARGET_API_RTAS
@@ -204,13 +204,13 @@ DfxPlugin::DfxPlugin(
 	mNumInputs = VST_NUM_INPUTS;
 	mNumOutputs = VST_NUM_OUTPUTS;
 
-	setUniqueID(PLUGIN_ID);
-	setNumInputs(VST_NUM_INPUTS);
-	setNumOutputs(VST_NUM_OUTPUTS);
+	TARGET_API_BASE_CLASS::setUniqueID(PLUGIN_ID);
+	TARGET_API_BASE_CLASS::setNumInputs(VST_NUM_INPUTS);
+	TARGET_API_BASE_CLASS::setNumOutputs(VST_NUM_OUTPUTS);
 
 	TARGET_API_BASE_CLASS::setProgram(0);  // set the current preset number to 0
 
-	noTail(true);  // until the plugin declares otherwise
+	TARGET_API_BASE_CLASS::noTail(true);  // until the plugin declares otherwise
 
 	// check to see if the host supports sending tempo and time information to VST plugins
 	// Note that the VST2 SDK (probably erroneously) wants a non-const string here,
@@ -220,18 +220,15 @@ DfxPlugin::DfxPlugin(
 
 	#if TARGET_PLUGIN_USES_MIDI
 	// tell host that we want to use special data chunks for settings storage
-	programsAreChunks();
+	TARGET_API_BASE_CLASS::programsAreChunks();
 	#endif
 
 	#if TARGET_PLUGIN_IS_INSTRUMENT
-	isSynth();
+	TARGET_API_BASE_CLASS::isSynth();
 	#endif
 
 	#if TARGET_PLUGIN_HAS_GUI
-	// XXX AEffGUIEditor registers itself, so we probably don't need to assign this
-	// to the member variable here (and probably should be using AEffect::setEditor?).
-	// Instead we can probably just call getEditor() if we need it.
-	editor = DFXGUI_NewEditorInstance(this);
+	setEditor(DFXGUI_NewEditorInstance(this).release());
 	#endif
 #endif
 // end VST stuff
@@ -1126,14 +1123,17 @@ void DfxPlugin::setsamplerate(double inSampleRate)
 	if ((mSampleRateChanged = (inSampleRate != DfxPlugin::mSampleRate)))
 	{
 #ifdef TARGET_API_AUDIOUNIT
-		// assume that sample-specified properties change in absolute duration when sample rate changes
-		if (auto const latencySamples = std::get_if<long>(&mLatency); latencySamples && (*latencySamples != 0))
+		if (mAUElementsHaveBeenCreated)
 		{
-			postupdate_latency();
-		}
-		if (auto const tailSizeSamples = std::get_if<long>(&mTailSize); tailSizeSamples && (*tailSizeSamples != 0))
-		{
-			postupdate_tailsize();
+			// assume that sample-specified properties change in absolute duration when sample rate changes
+			if (auto const latencySamples = std::get_if<long>(&mLatency); latencySamples && (*latencySamples != 0))
+			{
+				postupdate_latency();
+			}
+			if (auto const tailSizeSamples = std::get_if<long>(&mTailSize); tailSizeSamples && (*tailSizeSamples != 0))
+			{
+				postupdate_tailsize();
+			}
 		}
 #endif
 	}

dfx-library/dfxplugin.h

@@ -826,11 +826,11 @@ class DfxPlugin : public TARGET_API_BASE_CLASS
 
 #if TARGET_PLUGIN_USES_DSPCORE
 	template <class DSPCoreClass>
-	std::unique_ptr<DSPCoreClass> dspCoreFactory();
+	[[nodiscard]] std::unique_ptr<DSPCoreClass> dspCoreFactory();
 #ifdef TARGET_API_AUDIOUNIT
 	ausdk::AUBufferList mAsymmetricalInputBufferList;
 #else
-	std::unique_ptr<DfxPluginCore> dspCoreFactory();
+	[[nodiscard]] std::unique_ptr<DfxPluginCore> dspCoreFactory();
 	std::vector<std::unique_ptr<DfxPluginCore>> mDSPCores;  // we have to manage this ourselves outside of the AU SDK
 	std::vector<float> mAsymmetricalInputAudioBuffer;
 #endif
@@ -1391,10 +1391,10 @@ class CPluginControl_DfxCurvedFrequency : public CPluginControl_Frequency, publi
 	// call this in the plugin's constructor if it uses DSP cores for processing
 	#if TARGET_PLUGIN_USES_DSPCORE
 		// DFX_CORE_ENTRY is not useful for APIs other than AU, so it is defined as nothing
-		#define DFX_CORE_ENTRY(PluginCoreClass)							\
-			std::unique_ptr<DfxPluginCore> DfxPlugin::dspCoreFactory()	\
-			{															\
-				return dspCoreFactory<PluginCoreClass>();				\
+		#define DFX_CORE_ENTRY(PluginCoreClass)											\
+			[[nodiscard]] std::unique_ptr<DfxPluginCore> DfxPlugin::dspCoreFactory()	\
+			{																			\
+				return dspCoreFactory<PluginCoreClass>();								\
 			}
 	#endif
 
@@ -1419,17 +1419,17 @@ class CPluginControl_DfxCurvedFrequency : public CPluginControl_Frequency, publi
 	#ifdef TARGET_API_AUDIOSUITE
 		#define DFX_NewEffectProcess	DFX_NewEffectProcessAS
 	#endif
-	#define DFX_EFFECT_ENTRY(PluginClass)			\
-		CEffectProcess* DFX_NewEffectProcess()		\
-		{											\
-			try										\
-			{										\
-				return new PluginClass(nullptr);	\
-			}										\
-			catch (...)								\
-			{										\
-				return nullptr;						\
-			}										\
+	#define DFX_EFFECT_ENTRY(PluginClass)						\
+		[[nodiscard]] CEffectProcess* DFX_NewEffectProcess()	\
+		{														\
+			try													\
+			{													\
+				return new PluginClass(nullptr);				\
+			}													\
+			catch (...)											\
+			{													\
+				return nullptr;									\
+			}													\
 		}
 
 #endif  // TARGET_API_RTAS
@@ -1439,7 +1439,7 @@ class CPluginControl_DfxCurvedFrequency : public CPluginControl_Frequency, publi
 
 #if TARGET_PLUGIN_USES_DSPCORE
 template <class DSPCoreClass>
-std::unique_ptr<DSPCoreClass> DfxPlugin::dspCoreFactory()
+[[nodiscard]] std::unique_ptr<DSPCoreClass> DfxPlugin::dspCoreFactory()
 {
 	static_assert(std::is_base_of_v<DfxPluginCore, DSPCoreClass>);
 	auto core = std::make_unique<DSPCoreClass>(this);

dfxgui/dfxgui-auviewfactory.mm

@@ -117,7 +117,7 @@ - (NSView*) uiViewForAudioUnit:(AudioUnit)inAU withSize:(NSSize)inPreferredSize
 @implementation DGNSViewForAU
 //-----------------------------------------------------------------------------
 
-extern DfxGuiEditor* DFXGUI_NewEditorInstance(AudioUnit inEffectInstance);
+[[nodiscard]] extern std::unique_ptr<DfxGuiEditor> DFXGUI_NewEditorInstance(DGEditorListenerInstance inEffectInstance);
 
 //-----------------------------------------------------------------------------
 - (id) initWithAU:(AudioUnit)inAU preferredSize:(NSSize)inSize
@@ -129,7 +129,7 @@ - (id) initWithAU:(AudioUnit)inAU preferredSize:(NSSize)inSize
 		return nil;
 	}
 
-	mDfxGuiEditor.reset(DFXGUI_NewEditorInstance(inAU));
+	mDfxGuiEditor = DFXGUI_NewEditorInstance(inAU);
 	if (!mDfxGuiEditor)
 	{
 		return nil;

dfxgui/dfxguidialog.cpp

@@ -63,7 +63,7 @@ static bool DFXGUI_PressButton(VSTGUI::CTextButton* inButton, bool inState)
 //-----------------------------------------------------------------------------
 // Dialog Button
 //-----------------------------------------------------------------------------
-class DGDialogButton : public VSTGUI::CTextButton
+class DGDialogButton final : public VSTGUI::CTextButton
 {
 public:
 	DGDialogButton(VSTGUI::IControlListener* inListener, DGRect const& inRegion, DGDialog::Selection inSelection, VSTGUI::UTF8StringPtr inTitle)
@@ -179,7 +179,7 @@ class DGDialogButton : public VSTGUI::CTextButton
 //-----------------------------------------------------------------------------
 // Dialog Text Edit
 //-----------------------------------------------------------------------------
-class DGDialogTextEdit : public VSTGUI::CTextEdit
+class DGDialogTextEdit final : public VSTGUI::CTextEdit
 {
 public:
 	DGDialogTextEdit(VSTGUI::CRect const& inRegion, VSTGUI::IControlListener* inListener)

dfxgui/dfxguieditor.cpp

@@ -140,14 +140,10 @@ DfxGuiEditor::DfxGuiEditor(DGEditorListenerInstance inInstance)
 //-----------------------------------------------------------------------------
 DfxGuiEditor::~DfxGuiEditor()
 {
+	assert(!IsOpen());
 #ifdef TARGET_API_AUDIOUNIT
 	RemoveAUEventListeners();
 #endif
-
-	if (IsOpen())
-	{
-		close();
-	}
 }
 
 
@@ -231,7 +227,7 @@ void DfxGuiEditor::close()
 	CloseEditor();
 
 	frame->unregisterMouseObserver(this);
-	// zero the member frame before we delete it so that other asynchronous calls don't crash
+	// zero the member frame before we release it so that other asynchronous calls don't crash
 	auto const frame_temp = std::exchange(frame, nullptr);
 
 	for (auto& control : mControlsList)
@@ -240,10 +236,7 @@ void DfxGuiEditor::close()
 	}
 	mControlsList.clear();
 
-	if (frame_temp)
-	{
-		frame_temp->forget();
-	}
+	frame_temp->forget();
 
 	TARGET_API_EDITOR_BASE_CLASS::close();
 }

dfxgui/dfxguieditor.h

@@ -76,10 +76,10 @@ To contact the author, use the contact form at http://destroyfx.org/
 
 
 //-----------------------------------------------------------------------------
-#define DFX_EDITOR_ENTRY(PluginEditorClass)												\
-	DfxGuiEditor* DFXGUI_NewEditorInstance(DGEditorListenerInstance inEffectInstance)	\
-	{																					\
-		return new PluginEditorClass(inEffectInstance);									\
+#define DFX_EDITOR_ENTRY(PluginEditorClass)																			\
+	[[nodiscard]] std::unique_ptr<DfxGuiEditor> DFXGUI_NewEditorInstance(DGEditorListenerInstance inEffectInstance)	\
+	{																												\
+		return std::make_unique<PluginEditorClass>(inEffectInstance);												\
 	}