Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Events should move to "Past Events" based on their end time, not start time #399

Closed
nutjob4life opened this issue Mar 27, 2025 · 3 comments
Assignees
Labels
🧙‍♀️enhancement New feature or request ✅ QC Quality assurance confirmed
Milestone

Comments

@nutjob4life
Copy link
Member

nutjob4life commented Mar 27, 2025

🤔 Tell Us About the Feature

Royce asked in an email that an event should not move to "Past Events" when the event starts, but when it ends.

This will involve:

  • Adding a meeting end time field
  • Using the end time to figure out when to move an event to "Past Events"

As a bonus:

  • Hiding the "Join the online meeting button" for past events
@nutjob4life nutjob4life added the 🧙‍♀️enhancement New feature or request label Mar 27, 2025
@nutjob4life nutjob4life self-assigned this Mar 27, 2025
@nutjob4life nutjob4life added this to the 6.19 milestone Mar 27, 2025
nutjob4life added a commit that referenced this issue Apr 4, 2025
@nutjob4life
Copy link
Member Author

Ooof @hoodriverheather this was a doozy! But I got to learn about Django query annotations, ExpressionWrappers, and F-expressions.

To QC this:

  1. Visit the dev portal and log in
  2. Head to the "About EDRN" menu and choose "Committees and Collaborative Groups"
  3. Pick any committee, subcommittee, working group, or collaborative group
  4. From the NIH badge in the corner, choose "Add a child page" and choose the Committee Event type
  5. Fill in a title, a starting time (keep it close to the current time), and a duration (keep it short)
  6. Fill in a made-up meeting URL
  7. Click Publish then click View live

Confirm: you can see the "Join the online meeting" button

Then:

  1. Go back to the committee, subcommittee, working group, or collaborative group's page where you added the event from the breadcrumbs
  2. Confirm that your meeeting is upcoming, even when its start time passes
  3. Wait for the short duration you did in step №5 above
  4. Click on the event

Confirm: the "Join the online meeting" button is gone

Then:

  1. Go back to the committee, subcommittee, working group, or collaborative group's page where you added the event from the breadcrumbs
  2. Confirm that the meeting has moved to the Past Events button

@hoodriverheather
Copy link

@nutjob4life Works perfect!

@hoodriverheather hoodriverheather added the ✅ QC Quality assurance confirmed label Apr 7, 2025
@nutjob4life
Copy link
Member Author

@hoodriverheather thank you 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧙‍♀️enhancement New feature or request ✅ QC Quality assurance confirmed
Projects
None yet
Development

No branches or pull requests

2 participants