Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate terms which require creation #73

Open
tskir opened this issue Mar 23, 2021 · 5 comments
Open

Consolidate terms which require creation #73

tskir opened this issue Mar 23, 2021 · 5 comments
Assignees

Comments

@tskir
Copy link
Member

tskir commented Mar 23, 2021

As discussed on a call 2021-03-23:

  1. At the point of curation, a user adds a new term with label/description/cross-references. The app stores this information.
  2. At some point, a user goes to a dedicated page and gets a consolidated table of terms to be created and a link to an ontology issue tracker. It's then up to the user to contact the ontology about creating the new terms.

The point is to avoid having to submit each term separately.

@tskir
Copy link
Member Author

tskir commented Apr 6, 2021

Additional details discussed on the call 2021-04-06:

  • OLS will provide a link to the ontology issue tracker, to be displayed by the platform;
  • Once the issue submission is done, a user might want to add the same comment to all of the affected entities (for example: "Awaiting action in "). The page should allow the user to do that

@tskir
Copy link
Member Author

tskir commented Apr 20, 2021

Additional details discussed on the call 2021-04-20:

  • One way to represent the terms to the user is something like a table, so that this could be copy pasted into a spreadsheet or other processing system.
  • We decided that there will be two sets of states:
    • Requiring import → awaiting import. This can be resolved automatically when the import completes.
    • Requiring creation → awaiting creation. This will also have to be resolved manually.
  • The terms consolidation page will have two tables, downloadable as CSV. Configurable pagination will be considered.

@henrietteharmse
Copy link
Collaborator

Some questions to think about:

  • Should this be 1 page or 2 pages for import vs create terms.
  • Pagination.
  • Download table to TSV/CSV

@tskir
Copy link
Member Author

tskir commented Apr 20, 2021

For the use case with multiple preferred ontologies, people might want to submit not all terms at once but only some of them.. Thus it makes sense to give a user the ability to mark which terms to proceed to the next page. However, as @tudorgroza mentioned, it would a UI nightmare if the number of terms is more than a few dozen.

@tskir/@henrietteharmse to reach out to HCA/FAANG to find out how they currently do this and what are their requirements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants