Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update minimum cmake from 3.7 to remove warnings #7412

Open
derekbruening opened this issue Mar 28, 2025 · 0 comments · May be fixed by #7413
Open

Update minimum cmake from 3.7 to remove warnings #7412

derekbruening opened this issue Mar 28, 2025 · 0 comments · May be fixed by #7413
Assignees

Comments

@derekbruening
Copy link
Contributor

On my machine with cmake 3.31 I now get this warning (this is quite recent; my cmake may have been update recently):

CMake Deprecation Warning at CMakeLists.txt:49 (cmake_minimum_required):
  Compatibility with CMake < 3.10 will be removed from a future version of
  CMake.

  Update the VERSION argument <min> value.  Or, use the <min>...<max> syntax
  to tell CMake that the project requires at least <min> but has been updated
  to work with policies introduced by <max> or earlier.

The warning is repeated a dozen times for all our other files.

We may as well update the minimum. I'm thinking of 3.16 which is the Ubuntu 20.04 version.

@derekbruening derekbruening self-assigned this Mar 28, 2025
@derekbruening derekbruening changed the title Update minimum cmake from 3.9 to remove warnings Update minimum cmake from 3.7 to remove warnings Mar 28, 2025
derekbruening added a commit that referenced this issue Mar 28, 2025
Eliminates warnings with cmake 3.31 by updating our minimum supported
cmake from 3.7 to 3.16 (which is what ships with Ubuntu 20.04).

Fixes #7412
@derekbruening derekbruening linked a pull request Mar 28, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant