Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for additional Valgrind annotations #7384

Closed
derekbruening opened this issue Mar 20, 2025 · 0 comments · Fixed by #7385
Closed

Add support for additional Valgrind annotations #7384

derekbruening opened this issue Mar 20, 2025 · 0 comments · Fixed by #7385
Assignees
@derekbruening
Labels
Component-Dr.Memory

Comments

@derekbruening
Copy link
Contributor

For DynamoRIO/drmemory#107, Dr. Memory wants to recognize Valgrind annotations for marking custom allocators.
I'm thinking that these would be desirable:

  • VALGRIND_MAKE_MEM_UNDEFINED
  • VALGRIND_MAKE_MEM_DEFINED
  • VALGRIND_MALLOCLIKE_BLOCK
  • VALGRIND_FREELIKE_BLOCK

And these would make it easier to write tests:

  • VALGRIND_CHECK_MEM_IS_DEFINED
  • VALGRIND_CHECK_MEM_IS_ADDRESSABLE

Core DR just needs to recognize these and call a DR handler.
@derekbruening derekbruening self-assigned this Mar 20, 2025
derekbruening added a commit that referenced this issue Mar 20, 2025
@derekbruening
i#7384: Add support for 6 additional Valgrind annotations
9e85b9c 
Adds core DR support for recognizing and calling a client-register
handler for these 6 annotations which will be useful in Dr. Memory:
+ VALGRIND_MAKE_MEM_UNDEFINED
+ VALGRIND_MAKE_MEM_DEFINED
+ VALGRIND_CHECK_MEM_IS_DEFINED
+ VALGRIND_CHECK_MEM_IS_ADDRESSABLE
+ VALGRIND_MALLOCLIKE_BLOCK
+ VALGRIND_FREELIKE_BLOCK

Fixes #7384
@derekbruening derekbruening mentioned this issue Mar 20, 2025
Merged
derekbruening added a commit that referenced this issue Mar 20, 2025
@derekbruening
i#7384: Add support for 6 additional Valgrind annotations (#7385)
8ec1ccf 
Adds core DR support for recognizing and calling a client-register
handler for these 6 annotations which will be useful in Dr. Memory:
+ VALGRIND_MAKE_MEM_UNDEFINED
+ VALGRIND_MAKE_MEM_DEFINED
+ VALGRIND_CHECK_MEM_IS_DEFINED
+ VALGRIND_CHECK_MEM_IS_ADDRESSABLE
+ VALGRIND_MALLOCLIKE_BLOCK
+ VALGRIND_FREELIKE_BLOCK

Adds identification of these to the vg-annot test.

Fixes #7384
derekbruening added a commit to DynamoRIO/drmemory that referenced this issue Mar 20, 2025
@derekbruening
i#107 custom alloc: Pull in more DR Valgrind annotation support
dcc2904 
Updates DR to 8ec1ccf16 to pull in DynamoRIO/dynamorio#7384 adding
support for 6 additional Valgrind annotations we will need for custom
allocator support.

Issue: #107
@derekbruening derekbruening mentioned this issue Mar 20, 2025
Merged
derekbruening added a commit to DynamoRIO/drmemory that referenced this issue Mar 20, 2025
@derekbruening
i#107 custom alloc: Pull in more DR Valgrind annotation support (#2549)
d3c2add 
Updates DR to 8ec1ccf16 to pull in DynamoRIO/dynamorio#7384 adding
support for 6 additional Valgrind annotations we will need for custom
allocator support.

Issue: #107
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@derekbruening derekbruening

Labels
Component-Dr.Memory
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

i#7384: Add support for 6 additional Valgrind annotations DynamoRIO/dynamorio
1 participant
@derekbruening