Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CRASH schedule_stats tool at verbose 4 #7376

Closed
derekbruening opened this issue Mar 19, 2025 · 0 comments · Fixed by #7377
Closed

CRASH schedule_stats tool at verbose 4 #7376

derekbruening opened this issue Mar 19, 2025 · 0 comments · Fixed by #7377
Assignees
@derekbruening
Labels
Bug-ToolCrash Component-DrMemtrace

Comments

@derekbruening
Copy link
Contributor

Running the scheduler_stats drmemtrace tool at verbose 4 crashes when it hits an idle sequence: it tries to de-reference the input stream, which is null for idle.
@derekbruening derekbruening self-assigned this Mar 19, 2025
derekbruening added a commit that referenced this issue Mar 19, 2025
@derekbruening
i#7376: Fix schedule_stats crash at verbose 4
d35a886 
Fixes a crash in the drmemtrace schedule_stats tool at verbose 4 where
it tries to get the input stream on an idle sequence.

Tested on the new threadsig checked-in trace.  Unfortunately the unit
tests mock the stream interfaces and so can't reproduce this, and the
top-level at verbose 4 with a big enough trace to hit idle is too slow
for a good regression test.

Fixes #7376
@derekbruening derekbruening mentioned this issue Mar 19, 2025
Merged
derekbruening added a commit that referenced this issue Mar 19, 2025
@derekbruening
i#7376: Fix schedule_stats crash at verbose 4 (#7377)
42e36ca 
Fixes a crash in the drmemtrace schedule_stats tool at verbose 4 where
it tries to get the input stream on an idle sequence.

Tested on the new threadsig checked-in trace. Unfortunately the unit
tests mock the stream interfaces and so can't reproduce this, and the
top-level at verbose 4 with a big enough trace to hit idle is too slow
for a good regression test.

Fixes #7376
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@derekbruening derekbruening

Labels
Bug-ToolCrash Component-DrMemtrace
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

i#7376: Fix schedule_stats crash at verbose 4 DynamoRIO/dynamorio
1 participant
@derekbruening