Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation should mention details regarding input reads parsing #25

Open
cerebis opened this issue Jun 17, 2023 · 1 comment
Open

Comments

@cerebis
Copy link

cerebis commented Jun 17, 2023

It seems that the format of input reads is determined by file extension. I would encourage you to document this behaviour.

Also, this is brittle and should ideally encompass multiple conventions for extension syntax to be robust. A better "automagic" approach would be to inspect the begging file contents for a match to either header format.

In the end, you might find it simpler to assume a format and give users the option to declare the other.

Separate issue, but I am being lazy

GZIP read files do not appear to be supported? This really awkward with today's sequencer yields.

@Dreycey
Copy link
Owner

Dreycey commented Jun 17, 2023

@cerebis

These are great suggestions. I'll start by adding the current functionality to the README, and expand upon this by using an "automatic" approach that considers the first few initial sequences. Also, the suggestion of allowing for gzip makes a lot of sense. I'll add this functionality with the automatic tuning

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants