Description
In packages/server/src/services/notification.ts, several notification creation functions omit the volumeBackup field when inserting into the notifications table, even though their corresponding update functions include it.
Providers missing volumeBackup on creation:
createGotifyNotification
createNtfyNotification
createCustomNotification
createLarkNotification
createMattermostNotification
Providers that correctly include it (for reference):
- Slack, Telegram, Discord, Email, Resend, Pushover, Teams
Example comparison:
// Slack create — correct, includes volumeBackup
.values({
slackId: newSlack.slackId,
name: input.name,
appDeploy: input.appDeploy,
databaseBackup: input.databaseBackup,
volumeBackup: input.volumeBackup, // present
dokployRestart: input.dokployRestart,
})
// Gotify create — missing volumeBackup
.values({
gotifyId: newGotify.gotifyId,
name: input.name,
appDeploy: input.appDeploy,
databaseBackup: input.databaseBackup,
// volumeBackup NOT here
dokployRestart: input.dokployRestart,
})
Impact
Users who set up Gotify/Ntfy/Custom/Lark/Mattermost notifications and enable "Volume Backup" events will not receive volume backup notifications. The setting is silently discarded on creation, defaulting to false in the database. The workaround is to edit the notification after creation, which is confusing.
Fix
Add volumeBackup: input.volumeBackup to the insert values in all 5 affected creation functions. Copy-paste fix.
Description
In
packages/server/src/services/notification.ts, several notification creation functions omit thevolumeBackupfield when inserting into thenotificationstable, even though their corresponding update functions include it.Providers missing
volumeBackupon creation:createGotifyNotificationcreateNtfyNotificationcreateCustomNotificationcreateLarkNotificationcreateMattermostNotificationProviders that correctly include it (for reference):
Example comparison:
Impact
Users who set up Gotify/Ntfy/Custom/Lark/Mattermost notifications and enable "Volume Backup" events will not receive volume backup notifications. The setting is silently discarded on creation, defaulting to
falsein the database. The workaround is to edit the notification after creation, which is confusing.Fix
Add
volumeBackup: input.volumeBackupto the insert values in all 5 affected creation functions. Copy-paste fix.