-
-
Notifications
You must be signed in to change notification settings - Fork 976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow multiserver deployment as non-root user #1126
Comments
Yes, I haven't found a way to make it work with non-root users, for now it is required to use root users |
Related to Dokploy#1126 Add error handling for deployment failures with non-root users. * **apps/api/src/utils.ts** - Throw an error with a message when deployment fails. * **apps/dokploy/server/utils/deploy.ts** - Throw an error with a message when deployment fails. * **apps/dokploy/server/api/routers/server.ts** - Add a check for sudo password prompts in the `serverSetup` function and throw an error if detected. - Emit an error in the observable if a sudo password prompt is detected during server setup.
@Siumauricio Any particular blockers one could help with? I've modified the Remote Server setup script to include
Logs from installation look fine. Server security checks are showing some errors but those are false positives. This area is something that could be improved (starting with a message that erors those may be false positives if set up in a non standard way), but it's separate to the main issue. However, when I try to deploy a docker image I get:
which led me here: #1156 (comment) I'm keen on having my Remote Server set up non-root sudo user so any pointers where to look for issues would be appreciated! I'll try to fire up Dokploy locally alongisde a separate container acting as a Remote Server to see whether I can get this to work. Saying that, I've installed Dokploy via Couldn't we modify the scripts to allow for sudo as long as one has set up a admin group user with no passowrd sudo, i.e:
That check could be done alongside fixing the false positives in server security warnings. I'd be happy to document it all once I know what I'm facing by considering a PR to allow sudo users. |
What problem will this feature address?
Allowing full server best practice to disable root remote SSH login
Describe the solution you'd like
When attempting to deploy to a remote server using a non-root user, even one with full sudo privileges, the deployment fails without displaying any error messages or reasons. The process fails silently. However, if you switch the server's login user to root on the Dokploy dashboard settings and re-enable RootLogin, the deployment works as expected. This means that for now, root login must be enabled which may be problematic for some.
Describe alternatives you've considered
The workaround I consider for this is to check if sudo password prompts enabled for that user, if it's not it fails otherwise all sudo commands can be ran without the password prompt.
Additional context
No response
Will you send a PR to implement it?
Maybe, need help
The text was updated successfully, but these errors were encountered: