ci: opt into Node.js 24 for all workflow actions (bridge)#2
Merged
Conversation
Adds FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true at workflow level to suppress Node.js 20 deprecation warnings ahead of the June 2, 2026 forced migration. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
DojoGenesis
force-pushed
the
ci/node24-migration-bridge
branch
from
f51f0a9 to
ce7617a
Compare
Three lint findings from the CI run annotations: 1. ci.yml: upgrade golangci-lint-action @v6→@v7 and pin version: v2.11.4 golangci-lint-action@v6 rejects golangci-lint v2.x version strings; @v7 is required. Also pin away from `latest` for reproducible linting (mirrors PR #1). 2. internal/decisions/writer_test.go: check os.Chdir return values (errcheck) Both os.Chdir calls in TestNewWriter_EmptyPath discarded errors. Check the setup call with t.Fatalf and wrap the deferred restore in a closure so t.Errorf can be called on failure. 3. internal/skills/loader.go: remove dead HasSuffix branch (SA4017) parseFrontmatterLines had `if strings.HasSuffix(line, ":") { continue }` inside an `if idx == -1` block where both branches were `continue`. The HasSuffix call had no effect on control flow, triggering SA4017. Collapsed to a single continue with an explanatory comment. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: "true"at the workflow top level for all workflows that use external GitHub ActionsWorkflows touched
.github/workflows/ci.ymlTest plan
🤖 Generated with Claude Code