Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM Entries add exactly one level to the attached character when advancement is chosen regardless of levels field value #228

Open
pascwhale opened this issue Jan 4, 2022 · 1 comment
Labels
back end bug Something isn't working

Comments

@pascwhale
Copy link
Collaborator

Description

Attaching a DM Entry and choosing the advancement option adds exactly one level to the attached character, regardless if the levels fields contains 0 or a number greater than 1.

Expected Behavior

It is expected that the character advances the same number of levels as the input number.

Actual Behavior

The character advances exactly one level regardless of the level field value.

Steps to Reproduce

  1. Create a character and note the character's level.
  2. Create a DM Entry with a number greater than 1 or a value of 0.
  3. Attach a character.
  4. Choose the advancement option.
  5. Go to the characters tab, find the character attached to the last DM Entry. Notice that the character's level was incremented by 1.

Context

Users would expect the same number of levels to be added to their characters as the number they registered through the DM Entry.

Possible Fix

Add the same number of levels as the DM Entry value in the EntryController.php file. A possible fix would be to remove instances of the line $entryData['levels'] = 1; in that file.

Other

It would maybe be important to check why the $entryData values are being modified in the EntryController.php file. Would this cause any issues if the user were to edit the DM Entry?

Description

Additional Notes

@pascwhale pascwhale added the bug Something isn't working label Jan 4, 2022
@m-triassi
Copy link
Contributor

its implemented this way on purpose because its, sort of a rule. Typically its 1 level per entry but I suppose there might be edge cases where you could gain more than 1 level. Honestly i'd have to consult the Adventurers League rules more closely

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
back end bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants