Eng-521 repair and modernize eslint with flat config (#246)

* ENG-369: eslint with new flat configuration files.

* make it work in vscode

* coderabbit improvements

* make it look closer to turbo skeleton

* most additions have no obvious effect

* add preferArrows, naming conventions, max-params. (#241)

* Update tsconfig.json to include trailing comma in compilerOptions

---------

Co-authored-by: Michael Gartner <[email protected]>

Author: maparent

.vscode/settings.json

@@ -2,5 +2,7 @@
   "editor.formatOnSave": true,
   "prettier.requireConfig": true,
   "prettier.prettierPath": "./node_modules/prettier",
-  "editor.defaultFormatter": "esbenp.prettier-vscode"
+  "editor.defaultFormatter": "esbenp.prettier-vscode",
+  "eslint.useFlatConfig": true,
+  "eslint.workingDirectories": [{ "mode": "auto" }]
 }

apps/obsidian/eslint.config.mjs

@@ -0,0 +1,16 @@
+import { config } from "@repo/eslint-config/react-internal";
+
+export default [
+  ...config,
+  {
+    languageOptions: {
+      parserOptions: {
+        tsconfigRootDir: ".",
+        project: true,
+        ecmaFeatures: {
+          jsx: true,
+        },
+      },
+    },
+  },
+];

apps/obsidian/package.json

@@ -7,30 +7,30 @@
   "scripts": {
     "dev": "tsx scripts/dev.ts",
     "build": "tsx scripts/build.ts",
+    "lint": "eslint .",
+    "lint:fix": "eslint . --fix",
     "publish": "tsx scripts/publish-obsidian.ts"
   },
   "keywords": [],
   "author": "",
   "license": "Apache-2.0",
   "devDependencies": {
     "@octokit/core": "^6.1.2",
-    "@types/node": "^16.11.6",
-    "@typescript-eslint/eslint-plugin": "5.29.0",
-    "@typescript-eslint/parser": "5.29.0",
+    "@types/node": "^20",
     "autoprefixer": "^10.4.21",
     "builtin-modules": "3.3.0",
     "dotenv": "^16.4.5",
     "esbuild": "0.17.3",
     "obsidian": "^1.7.2",
     "postcss": "^8.5.3",
     "tailwindcss": "^3.4.17",
-    "tslib": "2.4.0",
+    "tslib": "2.5.1",
     "tsx": "^4.19.2",
-    "typescript": "4.7.4"
+    "typescript": "5.5.4"
   },
   "dependencies": {
     "react": "^19.0.0",
     "react-dom": "^19.0.0",
     "tailwindcss-animate": "^1.0.7"
   }
-}
+}

apps/obsidian/tsconfig.json

@@ -1,18 +1,16 @@
 {
   "extends": "@repo/typescript-config/react-library.json",
+  "include": ["**/*.ts"],
   "compilerOptions": {
     "baseUrl": ".",
+    "rootDir": ".",
     "inlineSourceMap": true,
     "inlineSources": true,
-    "module": "ESNext",
     "target": "ES6",
     "allowJs": true,
     "noImplicitAny": true,
-    "moduleResolution": "node",
     "importHelpers": true,
     "isolatedModules": true,
     "strictNullChecks": true,
-    "lib": ["DOM", "ES5", "ES6", "ES7"]
-  },
-  "include": ["**/*.ts"]
+  }
 }

apps/roam/eslint.config.mjs

@@ -0,0 +1,18 @@
+import { config } from "@repo/eslint-config/react-internal";
+
+// console.log(config.map((x)=>(x.languageOptions || {}).parserOptions));
+
+export default [
+  ...config,
+  {
+    languageOptions: {
+      parserOptions: {
+        tsconfigRootDir: ".",
+        project: true,
+        ecmaFeatures: {
+          jsx: true,
+        },
+      },
+    },
+  },
+];

apps/roam/package.json

@@ -7,6 +7,8 @@
     "dev": "tsx scripts/dev.ts",
     "build": "tsx scripts/build.ts",
     "deploy": "tsx scripts/deploy.ts",
+    "lint": "eslint .",
+    "lint:fix": "eslint . --fix",
     "publish": "tsx scripts/publish.ts"
   },
   "license": "Apache-2.0",

apps/roam/tsconfig.json

@@ -1,16 +1,11 @@
 {
-  "include": ["src", "src/types.d.ts", "tailwind.config.ts", "tests"],
-  "exclude": ["node_modules"],
   "extends": "@repo/typescript-config/react-library.json",
+  "include": ["src", "src/types.d.ts", "tailwind.config.ts", "tests", "scripts"],
   "compilerOptions": {
     "baseUrl": ".",
     "outDir": "dist",
-    "target": "ESNext",
-    "lib": ["DOM", "DOM.Iterable", "ESNext"],
     "allowJs": false,
     "esModuleInterop": false,
-    "module": "ESNext",
-    "moduleResolution": "Node",
     "forceConsistentCasingInFileNames": true,
     "jsx": "react",
     "noUncheckedIndexedAccess": false

apps/website/.eslintrc.js

@@ -0,0 +1,20 @@
+import { nextJsConfig } from "@repo/eslint-config/next-js";
+
+export default [
+  ...nextJsConfig,
+  // additions
+  {
+    languageOptions: {
+      parserOptions: {
+        tsconfigRootDir: ".",
+        project: true,
+        ecmaFeatures: {
+          jsx: true,
+        },
+      },
+    },
+  },
+  {
+    ignores: [".next/**"],
+  },
+];