address PR comments

Author: trangdoan982

apps/obsidian/src/components/GeneralSettings.tsx

@@ -195,7 +195,7 @@ const GeneralSettings = () => {
     plugin.settings.nodesFolderPath = nodesFolderPath;
     plugin.settings.canvasFolderPath = canvasFolderPath;
     plugin.settings.canvasAttachmentsFolderPath = canvasAttachmentsFolderPath;
-    plugin.settings.nodeTagHotkey = nodeTagHotkey || "\\";
+    plugin.settings.nodeTagHotkey = nodeTagHotkey || "";
     await plugin.saveSettings();
     new Notice("General settings saved");
     setHasUnsavedChanges(false);

apps/obsidian/src/components/NodeTagSuggestModal.tsx

@@ -1,4 +1,4 @@
-import { App, Editor } from "obsidian";
+import { Editor } from "obsidian";
 import { DiscourseNode } from "~/types";
 
 type NodeTagItem = {
@@ -16,7 +16,6 @@ export class NodeTagSuggestPopover {
   constructor(
     private editor: Editor,
     private nodeTypes: DiscourseNode[],
-    private app: App,
   ) {
     this.initializeItems();
   }
@@ -171,7 +170,7 @@ export class NodeTagSuggestPopover {
       itemEl.appendChild(textContainer);
 
       itemEl.addEventListener("mousedown", (e) => {
-        e.preventDefault(); 
+        e.preventDefault();
         e.stopPropagation();
         this.selectItem(item);
       });

apps/obsidian/src/index.ts

@@ -212,7 +212,6 @@ export default class DiscourseGraphPlugin extends Plugin {
           const popover = new NodeTagSuggestPopover(
             activeView.editor,
             this.settings.nodeTypes,
-            this.app,
           );
           popover.open();
         }