[ENG-565] node menu stealing click focus (#281)

* allow cmd c + cmd x events

* another fix for eng-591

Author: trangdoan982

apps/roam/src/components/DiscourseNodeMenu.tsx

@@ -100,6 +100,8 @@ const NodeMenu = ({
 
   const keydownListener = useCallback(
     (e: KeyboardEvent) => {
+      if (e.metaKey || e.ctrlKey || e.shiftKey) return;
+
       if (e.key === "ArrowDown") {
         const index = Number(
           menuRef.current?.getAttribute("data-active-index"),

apps/roam/src/utils/initializeObserversAndListeners.ts

@@ -257,7 +257,10 @@ export const initObservers = async ({
 
     const selection = window.getSelection();
 
-    if (!selection || selection.rangeCount === 0) return;
+    if (!selection || selection.rangeCount === 0 || !selection.focusNode) {
+      removeTextSelectionPopup();
+      return;
+    }
 
     const selectedText = selection.toString().trim();
 

apps/roam/src/utils/renderTextSelectionPopup.tsx

@@ -65,9 +65,9 @@ export const renderTextSelectionPopup = ({
 };
 
 export const removeTextSelectionPopup = () => {
-  if (currentPopupContainer) {
-    ReactDOM.unmountComponentAtNode(currentPopupContainer);
-    currentPopupContainer.remove();
-    currentPopupContainer = null;
+  const container = document.getElementById("discourse-text-selection-popup");
+  if (container) {
+    ReactDOM.unmountComponentAtNode(container);
+    container.remove();
   }
 };