Add bulk request exception static constructor

Author: stevebauman

src/Documents/DocumentManager.php

@@ -49,7 +49,7 @@ public function index(
         $response = $this->client->bulk($params);
 
         if ($response['errors']) {
-            throw new BulkRequestException($response);
+            throw BulkRequestException::fromResponse($response);
         }
 
         return $this;
@@ -87,7 +87,7 @@ public function delete(
         $response = $this->client->bulk($params);
 
         if ($response['errors']) {
-            throw new BulkRequestException($response);
+            throw BulkRequestException::fromResponse($response);
         }
 
         return $this;

src/Exceptions/BulkRequestException.php

@@ -6,15 +6,26 @@
 
 class BulkRequestException extends ErrorException
 {
+    /**
+     * Create a new bulk request exception from an OpenSearch response.
+     *
+     * @param  array<string, mixed>  $response
+     */
+    public static function fromResponse(array $response): self
+    {
+        return new self($response, self::makeMessageFromResponse($response));
+    }
+
     /**
      * Create a new bulk request exception instance.
      *
      * @param  array<string, mixed>  $response
      */
     public function __construct(
         protected array $response,
+        string $message = '',
     ) {
-        parent::__construct($this->makeErrorFromResponse());
+        parent::__construct($message);
     }
 
     /**
@@ -42,9 +53,9 @@ public function getResponse(): array
     /**
      * Create the exception message from the OpenSearch bulk response.
      */
-    protected function makeErrorFromResponse(): string
+    protected static function makeMessageFromResponse(array $response): string
     {
-        $items = $this->response['items'] ?? [];
+        $items = $response['items'] ?? [];
         $count = count($items);
 
         $reason = sprintf('%s did not complete successfully.', $count > 0 ? $count.' bulk operation(s)' : 'One or more');

src/Indices/Mapping.php

@@ -150,6 +150,7 @@ public function __call(string $method, array $parameters): self
     public function toArray(): array
     {
         $mapping = [];
+
         $properties = $this->properties->toArray();
 
         if (isset($this->isFieldNamesEnabled)) {

tests/Unit/Exceptions/BulkRequestExceptionTest.php

@@ -27,7 +27,7 @@
         ],
     ];
 
-    $exception = new BulkRequestException($response);
+    $exception = BulkRequestException::fromResponse($response);
 
     $this->assertSame($response, $exception->getResponse());
 });
@@ -55,7 +55,7 @@
         ],
     ];
 
-    $exception = new BulkRequestException($response);
+    $exception = BulkRequestException::fromResponse($response);
 
     $this->assertEquals(
         '1 bulk operation(s) did not complete successfully. Error: document_missing_exception. Reason: [_doc][5]: document missing. Catch the exception and use the DirectoryTree\OpenSearchAdapter\Exceptions\BulkRequestException::getResponse() method to get more details.',
@@ -101,7 +101,7 @@
         ],
     ];
 
-    $exception = new BulkRequestException($response);
+    $exception = BulkRequestException::fromResponse($response);
 
     $this->assertEquals(
         '2 bulk operation(s) did not complete successfully. First error: document_missing_exception. Reason: [_doc][5]: document missing. Catch the exception and use the DirectoryTree\OpenSearchAdapter\Exceptions\BulkRequestException::getResponse() method to get more details.',
@@ -125,7 +125,7 @@
         ],
     ];
 
-    $exception = new BulkRequestException($response);
+    $exception = BulkRequestException::fromResponse($response);
 
     $this->assertEquals(
         '1 bulk operation(s) did not complete successfully. Catch the exception and use the DirectoryTree\OpenSearchAdapter\Exceptions\BulkRequestException::getResponse() method to get more details.',
@@ -140,7 +140,7 @@
         'items' => [],
     ];
 
-    $exception = new BulkRequestException($response);
+    $exception = BulkRequestException::fromResponse($response);
 
     $this->assertEquals(
         'One or more did not complete successfully. Catch the exception and use the DirectoryTree\OpenSearchAdapter\Exceptions\BulkRequestException::getResponse() method to get more details.',