Merge pull request #1686 from DimensionDev/copilot/sub-pr-1644

Fix Kotlin 2.3.0 warnings to maintain allWarningsAsErrors

Author: Tlaster

shared/src/commonMain/kotlin/dev/dimension/flare/data/database/cache/mapper/Bluesky.kt

@@ -218,7 +218,6 @@ internal fun List<ListNotificationsNotification>.toDb(
                             when (reason) {
                                 ListNotificationsNotificationReason.Repost -> it.decodeAs<Repost>().subject
                                 ListNotificationsNotificationReason.Like -> it.decodeAs<Like>().subject
-                                else -> null
                             }
                         }?.uri
                         .let {
@@ -233,7 +232,6 @@ internal fun List<ListNotificationsNotification>.toDb(
                     when (reason) {
                         ListNotificationsNotificationReason.Repost -> "_repost"
                         ListNotificationsNotificationReason.Like -> "_like"
-                        else -> ""
                     }
                 val data =
                     DbStatusWithUser(

shared/src/commonMain/kotlin/dev/dimension/flare/data/datasource/misskey/FansPagingSource.kt

@@ -34,7 +34,7 @@ internal class FansPagingSource(
                     it.follower?.render(accountKey = accountKey)
                 },
             prevKey = null,
-            nextKey = response?.lastOrNull()?.id,
+            nextKey = response.lastOrNull()?.id,
         )
     }
 }

shared/src/commonMain/kotlin/dev/dimension/flare/data/datasource/misskey/FavouriteTimelineRemoteMediator.kt

@@ -50,9 +50,7 @@ internal class FavouriteTimelineRemoteMediator(
                         ),
                     )
                 }
-            } ?: return Result(
-                endOfPaginationReached = true,
-            )
+            }
 
         val notes = response.map { it.note }
         val data =

shared/src/commonMain/kotlin/dev/dimension/flare/data/datasource/misskey/FollowingPagingSource.kt

@@ -35,7 +35,7 @@ internal class FollowingPagingSource(
                     it.followee?.render(accountKey = accountKey)
                 },
             prevKey = null,
-            nextKey = response?.lastOrNull()?.id,
+            nextKey = response.lastOrNull()?.id,
         )
     }
 }

shared/src/commonMain/kotlin/dev/dimension/flare/data/datasource/misskey/HomeTimelineRemoteMediator.kt

@@ -46,9 +46,7 @@ internal class HomeTimelineRemoteMediator(
                         ),
                     )
                 }
-            } ?: return Result(
-                endOfPaginationReached = true,
-            )
+            }
 
         return Result(
             endOfPaginationReached = response.isEmpty(),

shared/src/commonMain/kotlin/dev/dimension/flare/data/datasource/misskey/HybridTimelineRemoteMediator.kt

@@ -41,9 +41,7 @@ internal class HybridTimelineRemoteMediator(
                         ),
                     )
                 }
-            } ?: return Result(
-                endOfPaginationReached = true,
-            )
+            }
 
         return Result(
             endOfPaginationReached = response.isEmpty(),

shared/src/commonMain/kotlin/dev/dimension/flare/data/datasource/misskey/ListTimelineRemoteMediator.kt

@@ -55,9 +55,7 @@ internal class ListTimelineRemoteMediator(
                             ),
                         )
                 }
-            } ?: return Result(
-                endOfPaginationReached = true,
-            )
+            }
 
         return Result(
             endOfPaginationReached = response.isEmpty(),

shared/src/commonMain/kotlin/dev/dimension/flare/data/datasource/misskey/LocalTimelineRemoteMediator.kt

@@ -43,9 +43,7 @@ internal class LocalTimelineRemoteMediator(
                         ),
                     )
                 }
-            } ?: return Result(
-                endOfPaginationReached = true,
-            )
+            }
 
         return Result(
             endOfPaginationReached = response.isEmpty(),

shared/src/commonMain/kotlin/dev/dimension/flare/data/datasource/misskey/MentionTimelineRemoteMediator.kt

@@ -43,9 +43,7 @@ internal class MentionTimelineRemoteMediator(
                         ),
                     )
                 }
-            } ?: return Result(
-                endOfPaginationReached = true,
-            )
+            }
 
         return Result(
             endOfPaginationReached = response.isEmpty(),

shared/src/commonMain/kotlin/dev/dimension/flare/data/datasource/misskey/MisskeyDataSource.kt

@@ -209,9 +209,7 @@ internal class MisskeyDataSource(
                 val user =
                     service
                         .usersShow(UsersShowRequest(username = name, host = host))
-
-                        ?.toDbUser(accountKey.host)
-                        ?: throw Exception("User not found")
+                        .toDbUser(accountKey.host)
                 database.userDao().insert(user)
             },
             cacheSource = {
@@ -231,9 +229,7 @@ internal class MisskeyDataSource(
                 val user =
                     service
                         .usersShow(UsersShowRequest(userId = id))
-
-                        ?.toDbUser(accountKey.host)
-                        ?: throw Exception("User not found")
+                        .toDbUser(accountKey.host)
                 database.userDao().insert(user)
             },
             cacheSource = {
@@ -315,8 +311,7 @@ internal class MisskeyDataSource(
                 val emojis =
                     service
                         .emojis()
-
-                        ?.emojis
+                        .emojis
                         .orEmpty()
                         .toImmutableList()
                 database.emojiDao().insert(
@@ -921,7 +916,7 @@ internal class MisskeyDataSource(
                 )
             }.fold(
                 onSuccess = {
-                    emit(it?.isFavorited == true)
+                    emit(it.isFavorited == true)
                 },
                 onFailure = {
                     emit(false)
@@ -1053,7 +1048,7 @@ internal class MisskeyDataSource(
                     ),
                 )
         }.onSuccess { response ->
-            if (response?.id != null) {
+            if (response.id != null) {
                 MemoryPagingSource.updateWith<UiList>(
                     key = listKey,
                 ) {
@@ -1122,7 +1117,7 @@ internal class MisskeyDataSource(
                         UsersListsShowRequest(
                             listId = listId,
                         ),
-                    )?.render() ?: throw Exception("List not found")
+                    ).render()
             },
         )
 
@@ -1207,8 +1202,8 @@ internal class MisskeyDataSource(
                         UsersShowRequest(
                             userId = userKey.id,
                         ),
-                    )?.toDbUser(accountKey.host)
-                    ?.render(accountKey)
+                    ).toDbUser(accountKey.host)
+                    .render(accountKey)
             MemoryPagingSource.updateWith(
                 key = listMemberKey(listId),
             ) {
@@ -1224,7 +1219,7 @@ internal class MisskeyDataSource(
                             listId = listId,
                         ),
                     )
-            if (list?.id != null) {
+            if (list.id != null) {
                 MemCacheable.updateWith<ImmutableList<UiList>>(
                     key = userListsKey(userKey),
                 ) {