refactor: enable unreachable_pub lint (#522)

Author: PavloMyroniuk-apriorit

Cargo.toml

@@ -33,6 +33,9 @@ exclude = [
 [workspace.lints.rust]
 unexpected_cfgs = { level = "warn", check-cfg = ['cfg(fuzzing)'] }
 
+# == Style, readability == #
+unreachable_pub = "warn"
+
 [workspace.dependencies]
 uuid = { version = "1.18", default-features = false }
 tracing = { version = "0.1",  default-features = false }

crates/dpapi-pdu/src/gkdi.rs

@@ -339,7 +339,7 @@ impl arbitrary::Arbitrary<'_> for FfcdhParameters {
         let bits = field_order.bits().max(generator.bits());
 
         Ok(Self {
-            key_length: (bits as u32).div_ceil(8),
+            key_length: bits.div_ceil(8),
             field_order,
             generator,
         })
@@ -461,7 +461,7 @@ impl arbitrary::Arbitrary<'_> for FfcdhKey {
         let bits = field_order.bits().max(generator.bits().max(public_key.bits()));
 
         Ok(Self {
-            key_length: (bits as u32).div_ceil(8),
+            key_length: bits.div_ceil(8),
             field_order,
             generator,
             public_key,
@@ -611,7 +611,7 @@ impl arbitrary::Arbitrary<'_> for EcdhKey {
 
         Ok(Self {
             curve: u.arbitrary()?,
-            key_length: (bits as u32).div_ceil(8),
+            key_length: bits.div_ceil(8),
             x,
             y,
         })

crates/dpapi-pdu/src/rpc/bind.rs

@@ -26,7 +26,7 @@ impl From<BindError> for DecodeError {
     }
 }
 
-pub type BindResult<T> = core::result::Result<T, BindError>;
+pub(super) type BindResult<T> = core::result::Result<T, BindError>;
 
 /// [BindTimeFeatureNegotiationBitmask](https://learn.microsoft.com/en-us/openspecs/windows_protocols/ms-rpce/cef529cc-77b5-4794-85dc-91e1467e80f0)
 ///

crates/dpapi-pdu/src/rpc/pdu.rs

@@ -79,7 +79,7 @@ impl From<PduError> for DecodeError {
     }
 }
 
-pub type PduResult<T> = core::result::Result<T, PduError>;
+pub(super) type PduResult<T> = core::result::Result<T, PduError>;
 
 #[derive(Debug, Clone, Copy, PartialEq, Eq, Default, FromPrimitive)]
 #[cfg_attr(feature = "arbitrary", derive(arbitrary::Arbitrary))]

crates/dpapi-transport/src/connect_options.rs

@@ -33,7 +33,7 @@ pub enum Error {
     UrlParse(#[from] url::ParseError),
 }
 
-pub type Result<T> = core::result::Result<T, Error>;
+pub(crate) type Result<T> = core::result::Result<T, Error>;
 
 /// Target server connection options.
 pub enum ConnectOptions {

crates/dpapi-web/src/session_token.rs

@@ -7,7 +7,7 @@ use wasm_bindgen::prelude::*;
 use wasm_bindgen_futures::JsFuture;
 
 /// This function wraps a JS-function into a Rust closure which we can pass into the Rust API.
-pub fn session_token_fn(get_session_token: js_sys::Function) -> Box<GetSessionTokenFn> {
+pub(crate) fn session_token_fn(get_session_token: js_sys::Function) -> Box<GetSessionTokenFn> {
     Box::new(move |session_id: Uuid, destination: Url| {
         let get_session_token = get_session_token.clone();
         Box::pin(async move {

crates/dpapi-web/src/transport.rs

@@ -8,13 +8,13 @@ use gloo_net::websocket::futures::WebSocket;
 use url::Url;
 use uuid::Uuid;
 
-pub trait AsyncReadWrite: AsyncRead + AsyncWrite + Unpin {}
+pub(crate) trait AsyncReadWrite: AsyncRead + AsyncWrite + Unpin {}
 
 impl<T> AsyncReadWrite for T where T: AsyncRead + AsyncWrite + Unpin + 'static {}
 
 type ErasedReadWrite = Box<dyn AsyncReadWrite>;
 
-pub struct FuturesStream<S> {
+pub(crate) struct FuturesStream<S> {
     stream: S,
 }
 
@@ -65,7 +65,7 @@ where
 /// WASM transport.
 ///
 /// It uses the WEB API under the hood to open the WS connection.
-pub struct WasmTransport;
+pub(crate) struct WasmTransport;
 
 impl WasmTransport {
     /// Connects to the RPC server via the Devolutions Gateway tunneled connection.

crates/dpapi/src/crypto/kout.rs

@@ -1,6 +1,6 @@
 macro_rules! kout {
     ($name:ident, $size:ident) => {
-        pub struct $name;
+        pub(crate) struct $name;
 
         impl digest::crypto_common::KeySizeUser for $name {
             type KeySize = digest::consts::$size;

crates/dpapi/src/sid.rs

@@ -14,7 +14,7 @@ pub enum SidError {
 static SID_PATTERN: LazyLock<Regex> =
     LazyLock::new(|| Regex::new(r"^S-(\d)-(\d+)(?:-\d+){1,15}$").expect("valid SID regex"));
 
-pub fn sid_to_bytes(sid: &str) -> Result<Vec<u8>> {
+pub(crate) fn sid_to_bytes(sid: &str) -> Result<Vec<u8>> {
     if !SID_PATTERN.is_match(sid) {
         Err(SidError::InvalidSid(sid.to_owned()))?;
     }
@@ -53,7 +53,7 @@ pub fn sid_to_bytes(sid: &str) -> Result<Vec<u8>> {
     Ok(data)
 }
 
-pub fn ace_to_bytes(sid: &str, access_mask: u32) -> Result<Vec<u8>> {
+pub(crate) fn ace_to_bytes(sid: &str, access_mask: u32) -> Result<Vec<u8>> {
     let sid = sid_to_bytes(sid)?;
 
     let mut data = Vec::new();
@@ -67,7 +67,7 @@ pub fn ace_to_bytes(sid: &str, access_mask: u32) -> Result<Vec<u8>> {
     Ok(data)
 }
 
-pub fn acl_to_bytes(aces: &[Vec<u8>]) -> Result<Vec<u8>> {
+pub(crate) fn acl_to_bytes(aces: &[Vec<u8>]) -> Result<Vec<u8>> {
     let ace_data_len = aces.iter().map(|a| a.len()).sum::<usize>();
 
     let mut data = Vec::new();
@@ -85,7 +85,12 @@ pub fn acl_to_bytes(aces: &[Vec<u8>]) -> Result<Vec<u8>> {
     Ok(data)
 }
 
-pub fn sd_to_bytes(owner: &str, group: &str, sacl: Option<&[Vec<u8>]>, dacl: Option<&[Vec<u8>]>) -> Result<Vec<u8>> {
+pub(crate) fn sd_to_bytes(
+    owner: &str,
+    group: &str,
+    sacl: Option<&[Vec<u8>]>,
+    dacl: Option<&[Vec<u8>]>,
+) -> Result<Vec<u8>> {
     // Self-Relative.
     let mut control: u16 = 0b10000000 << 8;
 

crates/winscard/src/card_capability_container.rs

@@ -5,7 +5,7 @@ use crate::tlv_tags;
 // ccc - Card Capability Container
 // Table 8. Card Capability Container
 // https://nvlpubs.nist.gov/nistpubs/SpecialPublications/NIST.SP.800-73-4.pdf#page=39
-pub fn build_ccc() -> Vec<u8> {
+pub(crate) fn build_ccc() -> Vec<u8> {
     let mut ccc = Vec::new();
 
     ccc.extend_from_slice(&[tlv_tags::DATA, 0x33]);