fix issues

Author: AlisherAmonulloev

ASP.NET Core/package-lock.json

@@ -8,7 +8,7 @@
     "watch": "ng build --watch --configuration development",
     "test": "ng test",
     "lint-html": "prettier --check .",
-    "lint-ts": "eslint --ext .ts .",
+    "lint-ts": "eslint --ext .ts . --fix",
     "lint-css": "stylelint src/**/*.{css,scss} --allow-empty-input",
     "lint": "npm-run-all -p -c lint-ts lint-css lint-html"
   },

Angular/package.json

@@ -1,7 +1,15 @@
-<dx-data-grid id="gridContainer" [dataSource]="dataSource" [showBorders]="true"
-  (onEditorPreparing)="onEditorPreparing($event)" (onSelectionChanged)="onSelectionChanged($event)">
-
-  <dxo-selection selectAllMode="allPages" showCheckBoxesMode="onClick" mode="multiple"></dxo-selection>
+<dx-data-grid
+  id="gridContainer"
+  [dataSource]="dataSource"
+  [showBorders]="true"
+  (onEditorPreparing)="onEditorPreparing($event)"
+  (onSelectionChanged)="onSelectionChanged($event)"
+>
+  <dxo-selection
+    selectAllMode="allPages"
+    showCheckBoxesMode="onClick"
+    mode="multiple"
+  ></dxo-selection>
 
   <dxi-column dataField="Prefix" [width]="60" caption="Title"></dxi-column>
   <dxi-column dataField="FirstName"></dxi-column>
@@ -11,5 +19,4 @@
   <dxi-column dataField="Position" [width]="130"></dxi-column>
   <dxi-column dataField="BirthDate" [width]="100" dataType="date"></dxi-column>
   <dxi-column dataField="Approved" [visible]="false"></dxi-column>
-
 </dx-data-grid>

Angular/src/app/app.component.html

@@ -1,14 +1,12 @@
 import { Component, ViewChild } from '@angular/core';
 import { DxDataGridComponent } from 'devextreme-angular';
 
-import { Employee, Service } from './app.service';
-
-import dxDataGrid from 'devextreme/ui/data_grid';
+import dxDataGrid, { SelectionChangedEvent } from 'devextreme/ui/data_grid';
 import dxCheckBox, {
   InitializedEvent,
   ValueChangedEvent,
 } from 'devextreme/ui/check_box';
-import { SelectionChangedEvent } from 'devextreme/ui/data_grid';
+import { Employee, Service } from './app.service';
 import { EditorPreparingEventEx } from './app.types';
 
 @Component({
@@ -19,10 +17,12 @@ import { EditorPreparingEventEx } from './app.types';
 })
 export class AppComponent {
   @ViewChild(DxDataGridComponent, { static: false })
-  dataGrid!: DxDataGridComponent;
+    dataGrid!: DxDataGridComponent;
 
   dataSource: Employee[];
+
   selectAllCheckBox!: dxCheckBox;
+
   checkBoxUpdating = false;
 
   constructor(service: Service) {
@@ -31,11 +31,11 @@ export class AppComponent {
     this.onSelectionChanged = this.onSelectionChanged.bind(this);
   }
 
-  isSelectable(item: Employee) {
+  isSelectable(item: Employee): boolean {
     return item.Approved;
   }
 
-  isSelectAll = (dataGrid: dxDataGrid) => {
+  isSelectAll = (dataGrid: dxDataGrid): boolean | undefined => {
     const selectableItems = this.dataSource.filter(this.isSelectable);
     const selectedRowKeys = dataGrid.option('selectedRowKeys');
 
@@ -44,19 +44,18 @@ export class AppComponent {
     }
     return selectedRowKeys.length >= selectableItems.length ? true : undefined;
   };
-  onEditorPreparing(e: EditorPreparingEventEx<Employee, number>) {
+
+  onEditorPreparing(e: EditorPreparingEventEx<Employee, number>): void {
     if (e.type !== 'selection') return;
 
-    if (e.parentType === 'dataRow' && e.row && !this.isSelectable(e.row.data))
-      e.editorOptions.disabled = true;
+    if (e.parentType === 'dataRow' && e.row && !this.isSelectable(e.row.data)) e.editorOptions.disabled = true;
     if (e.parentType === 'headerRow') {
       const dataGrid = e.component;
       e.editorOptions.value = this.isSelectAll(dataGrid);
-      e.editorOptions.onInitialized = (e: InitializedEvent) => {
+      e.editorOptions.onInitialized = (e: InitializedEvent): void => {
         if (e.component) this.selectAllCheckBox = e.component;
       };
-      e.editorOptions.onValueChanged = (e: ValueChangedEvent) => {
-
+      e.editorOptions.onValueChanged = (e: ValueChangedEvent): void => {
         if (!e.event) {
           if (e.previousValue && !this.checkBoxUpdating) {
             e.component.option('value', e.previousValue);
@@ -67,22 +66,20 @@ export class AppComponent {
         if (this.isSelectAll(dataGrid) === e.value) {
           return;
         }
-
         e.value ? dataGrid.selectAll() : dataGrid.deselectAll();
         e.event.preventDefault();
       };
     }
   }
 
-  onSelectionChanged(e: SelectionChangedEvent<Employee, number>) {
+  async onSelectionChanged(e: SelectionChangedEvent<Employee, number>): Promise<void> {
     const deselectRowKeys: number[] = [];
-    const dataGrid = e.component
+    const dataGrid = e.component;
     e.selectedRowsData.forEach((item) => {
-      if (!this.isSelectable(item))
-        deselectRowKeys.push(dataGrid.keyOf(item));
+      if (!this.isSelectable(item)) deselectRowKeys.push(dataGrid.keyOf(item));
     });
     if (deselectRowKeys.length) {
-      dataGrid.deselectRows(deselectRowKeys);
+      await dataGrid.deselectRows(deselectRowKeys);
     }
     this.checkBoxUpdating = true;
     this.selectAllCheckBox.option('value', this.isSelectAll(dataGrid));

Angular/src/app/app.component.ts

@@ -1,21 +1,21 @@
 import { NgModule } from '@angular/core';
 import { BrowserModule } from '@angular/platform-browser';
-import { DxButtonModule } from "devextreme-angular/ui/button";
-import { DxDataGridModule } from "devextreme-angular/ui/data-grid"
+import { DxButtonModule } from 'devextreme-angular/ui/button';
+import { DxDataGridModule } from 'devextreme-angular/ui/data-grid';
 import { AppRoutingModule } from './app-routing.module';
 import { AppComponent } from './app.component';
 
 @NgModule({
   declarations: [
-    AppComponent
+    AppComponent,
   ],
   imports: [
     BrowserModule,
     AppRoutingModule,
     DxDataGridModule,
-    DxButtonModule
+    DxButtonModule,
   ],
   providers: [],
-  bootstrap: [AppComponent]
+  bootstrap: [AppComponent],
 })
 export class AppModule { }

Angular/src/app/app.module.ts

@@ -79,7 +79,7 @@ let employees: Employee[] = [
     BirthDate: '1977/11/22',
     HireDate: '1998/04/23',
     Notes:
-      "Greta has been DevAV's HR Manager since 2003. She joined DevAV from Sonee Corp.\r\n\r\nGreta is currently training for the NYC marathon. Her best marathon time is 4 hours. Go Greta.",
+      'Greta has been DevAV\'s HR Manager since 2003. She joined DevAV from Sonee Corp.\r\n\r\nGreta is currently training for the NYC marathon. Her best marathon time is 4 hours. Go Greta.',
     Address: '1700 S Grandview Dr.',
     State: 'Georgia',
     City: 'Atlanta',
@@ -113,7 +113,7 @@ let employees: Employee[] = [
     BirthDate: '1974/11/15',
     HireDate: '2005/05/11',
     Notes:
-      "Sandra is a CPA and has been our controller since 2008. She loves to interact with staff so if you've not met her, be certain to say hi.\r\n\r\nSandra has 2 daughters both of whom are accomplished gymnasts.",
+      'Sandra is a CPA and has been our controller since 2008. She loves to interact with staff so if you\'ve not met her, be certain to say hi.\r\n\r\nSandra has 2 daughters both of whom are accomplished gymnasts.',
     Address: '4600 N Virginia Rd.',
     State: 'Utah',
     City: 'Beaver',
@@ -180,7 +180,7 @@ let employees: Employee[] = [
     BirthDate: '1982/08/14',
     HireDate: '2012/04/14',
     Notes:
-      "If you are like the rest of us at DevAV, then you've probably reached out for help from Taylor. He does a great job as a member of our IT department.",
+      'If you are like the rest of us at DevAV, then you\'ve probably reached out for help from Taylor. He does a great job as a member of our IT department.',
     Address: '7776 Torreyson Dr',
     State: 'California',
     City: 'San Jose',
@@ -190,7 +190,7 @@ let employees: Employee[] = [
 
 @Injectable()
 export class Service {
-  getEmployees() {
+  getEmployees(): Employee[] {
     return employees;
   }
 }

Angular/src/app/app.service.ts

@@ -2,4 +2,4 @@ import { EditorPreparingEvent } from 'devextreme/ui/data_grid';
 
 export type EditorPreparingEventEx<TRowData = any, TKey = any> = EditorPreparingEvent<TRowData, TKey> & {
   type?: string;
-}
+};

Angular/src/app/app.types.ts

@@ -1,13 +1,13 @@
-<!doctype html>
+<!DOCTYPE html>
 <html lang="en">
-<head>
-  <meta charset="utf-8">
-  <title>Angular</title>
-  <base href="/">
-  <meta name="viewport" content="width=device-width, initial-scale=1">
-  <link rel="icon" type="image/x-icon" href="favicon.ico">
-</head>
-<body>
-  <app-root></app-root>
-</body>
+  <head>
+    <meta charset="utf-8" />
+    <title>Angular</title>
+    <base href="/" />
+    <meta name="viewport" content="width=device-width, initial-scale=1" />
+    <link rel="icon" type="image/x-icon" href="favicon.ico" />
+  </head>
+  <body>
+    <app-root></app-root>
+  </body>
 </html>

Angular/src/index.html

@@ -3,4 +3,5 @@ import { platformBrowserDynamic } from '@angular/platform-browser-dynamic';
 import { AppModule } from './app/app.module';
 
 platformBrowserDynamic().bootstrapModule(AppModule)
+  // @eslint-disable-next-line no-console
   .catch((err) => console.error(err));