fix: replace commit() with apply() to allow async saving of Shared Preferences (#182)

rabiaq123 · web-flow · commit 93a3b4f19005 · 2023-12-15T09:45:39.000-05:00
diff --git a/android-client-sdk/src/main/java/com/devcycle/sdk/android/util/DVCSharedPrefs.kt b/android-client-sdk/src/main/java/com/devcycle/sdk/android/util/DVCSharedPrefs.kt
@@ -57,7 +57,6 @@ internal class DVCSharedPrefs(context: Context) {
     fun saveString(value: String, key: String) {
         try {
             preferences.edit().putString(key, value).apply()
-            preferences.edit().commit()
         } catch (e: JsonProcessingException) {
             DevCycleLogger.e(e, e.message)
         }

Original file line number	Diff line number	Diff line change
`@@ -57,7 +57,6 @@ internal class DVCSharedPrefs(context: Context) {`
`57`	`57`	`fun saveString(value: String, key: String) {`
`58`	`58`	`try {`
`59`	`59`	`preferences.edit().putString(key, value).apply()`
`60`		`- preferences.edit().commit()`
`61`	`60`	`} catch (e: JsonProcessingException) {`
`62`	`61`	`DevCycleLogger.e(e, e.message)`
`63`	`62`	`}`