Only define commit-lock-file-summary when the commit-msg input is explicitly defined (non-empty) #210
Description
It is possible to configure commit-lock-file-summary via a flake's nixConfig or via global nix config (e.g. specified in the install-nix action).
However, if --commit-lock-file-summary (or more precisely, --option commit-lockfile-summary) is supplied at the CLI, the configured value will be overridden by the value supplied at the CLI.
Instead, I'd propose removing the commit-msg input's default, and then only doing .concat(lockfileSummaryFlags) when commitMessage is truthy (non-empty). Alternatively, lockfileSummaryFlags could itself be an empty string when commitMessage is.
The default value specified in the input is usually1 identical to the default used by nix, so relying on nix's default when the input isn't defined seems like a reasonable behaviour.
The input:
Lines 12 to 15 in d6b4710
The lockfileSummaryFlags definition:
Lines 12 to 22 in d6b4710
The concat:
Line 30 in d6b4710
Footnotes
-
for top-level
flake.lockfiles it is identical. For nestedflake.lockfiles nix will default the commit summary to something likepath/to/flake.lock: Updaterelative to the root of the flake's source repo. ↩