Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This still needs at least updates to the tests, but wanted to get it out for feedback before going further. #1

Closed
Denis5433 opened this issue Feb 11, 2025 · 0 comments
Assignees
Labels
bug Something isn't working duplicate This issue or pull request already exists good first issue Good for newcomers help wanted Extra attention is needed invalid This doesn't seem right question Further information is requested

Comments

@Denis5433
Copy link
Owner

This still needs at least updates to the tests, but wanted to get it out for feedback before going further.

The idea here is to cache all the IETF meeting proceedings for a day and refresh the cache via celery. To avoid long-running celery jobs, the refresh task is designed to run hourly but only to update a couple proceedings at a time. We'll hopefully have a better method for managing the proceedings content in place before we reach more than 2-3 proceedings falling into any bin.

There were a few date parameters being supplied to the proceedings template but it looks to me like those must be relics. I traced the templates and don't see where any of the things I removed were being used indirectly. In view of that, it may be possible to adjust the boundary of the cached HTML fragment.

To avoid serving misinformation around the time when a meeting's proceedings are finalized, I've added that value to the cache key. This may result in one or a few long-running HTTP requests if we get a few people requesting the proceedings after the switch. We could consider refreshing the current proceedings immediately upon finalizing to avoid / reduce the cross section to that.

Originally posted by @jennifer-richards in ietf-tools/datatracker#8449

@Denis5433 Denis5433 added bug Something isn't working duplicate This issue or pull request already exists help wanted Extra attention is needed good first issue Good for newcomers invalid This doesn't seem right labels Feb 11, 2025
@Denis5433 Denis5433 self-assigned this Feb 11, 2025
@Denis5433 Denis5433 added the question Further information is requested label Feb 11, 2025
Repository owner locked and limited conversation to collaborators Feb 11, 2025
Repository owner unlocked this conversation Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working duplicate This issue or pull request already exists good first issue Good for newcomers help wanted Extra attention is needed invalid This doesn't seem right question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant