Skip to content

UNST-9429: Freezing point is wrongly computed for background salinity #430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thomas-pijls wants to merge 7 commits into
base: main
Choose a base branch
from
Open

UNST-9429: Freezing point is wrongly computed for background salinity #430

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a42ecf4
UNST-9414:uploaded new *.mdu files to minio
thomas-pijls Dec 4, 2025
f1ebe74
Merge branch 'main' of https://github.com/Deltares/Delft3D
thomas-pijls Dec 5, 2025
a028af9
Improved freezing point computation with salinity to support models w…
thomas-pijls Dec 5, 2025
89201d3
Reset testbench config
thomas-pijls Dec 5, 2025
0644b67
Added testcase
thomas-pijls Dec 8, 2025
f0d4da8
Made testcase working
thomas-pijls Dec 8, 2025
1f9a544
Set temperature tolerance of new testcase to 1e-3
thomas-pijls Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 22 additions & 10 deletions ...wfm/packages/dflowfm_kernel/src/dflowfm_kernel/compute_transport/extract_constituents.f90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ subroutine extract_constituents()
use m_fm_icecover, only: freezing_temperature
use m_get_kbot_ktop, only: getkbotktop
use m_missing, only: dmiss
use m_physcoef, only: salinity_max, salinity_min, use_salinity_freezing_point, temperature_max, temperature_min
use m_physcoef, only: salinity_max, salinity_min, use_salinity_freezing_point, backgroundsalinity, temperature_max, temperature_min
use m_plotdots, only: numdots
use m_sediment, only: mxgr, sed, stm_included, stmpar, ssccum, upperlimitssc
use m_transport, only: isalt, ised1, ispir, itemp, constituents, maserrsed
Expand Down Expand Up @@ -135,15 +135,27 @@ subroutine extract_constituents()
end if

cells_with_min_limit = 0
if (isalt > 0 .and. use_salinity_freezing_point) then ! only at surface limit to freezing point
do kk = 1, ndx
k = ktop(kk)
freezing_point_temperature = real(freezing_temperature(real(constituents(isalt, k), fp)), dp)
if (constituents(itemp, k) < freezing_point_temperature) then
constituents(itemp, k) = freezing_point_temperature
cells_with_min_limit = cells_with_min_limit + 1
end if
end do

if (use_salinity_freezing_point) then
if (isalt > 0) then ! if salinity is modeled, use local salinity to determine freezing point
do kk = 1, ndx
k = ktop(kk)
freezing_point_temperature = real(freezing_temperature(real(constituents(isalt, k), fp)), dp)
if (constituents(itemp, k) < freezing_point_temperature) then
constituents(itemp, k) = freezing_point_temperature
cells_with_min_limit = cells_with_min_limit + 1
end if
end do
else if (isalt == 0) then ! if salinity is not modeled, use background salinity to determine freezing point
freezing_point_temperature = real(freezing_temperature(backgroundsalinity), dp)
do kk = 1, ndx
k = ktop(kk)
if (constituents(itemp, k) < freezing_point_temperature) then
constituents(itemp, k) = freezing_point_temperature
cells_with_min_limit = cells_with_min_limit + 1
end if
end do
end if
end if

if (temperature_min /= dmiss) then
Expand Down
17 changes: 17 additions & 0 deletions test/deltares_testbench/configs/include/dimr_dflowfm_all_but_validation_cases.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2230,6 +2230,23 @@
</file>
</checks>
</testCase>
<testCase name="e02_f006_c176_freezing_with_background_salinity" ref="dflowfm_default">
<path version="2025-12-08T14:08:55.403000">e02_dflowfm/f006_external_forcing/c176_freezing_with_background_salinity</path>
<maxRunTime>3600.0</maxRunTime>
<checks>
<file name="output/winter97_saltwater-2_map.nc" type="netcdf">
<parameters>
<parameter name="mesh2d_ice_area_fraction" toleranceAbsolute="0.0001" />
<parameter name="mesh2d_ice_thickness" toleranceAbsolute="0.0001" />
</parameters>
</file>
<file name="output/winter97_saltwater-2_his.nc" type="netcdf">
<parameters>
<parameter name="temperature" toleranceAbsolute="0.001" />
</parameters>
</file>
</checks>
</testCase>
<testCase name="e02_f008_c010_ws_bedlevel_asdefault" ref="dflowfm_default">
<path version="2025-10-15T15:15:48.243000">e02_dflowfm/f008_network/c010_ws_bedlevel_asdefault</path>
<maxRunTime>15000.0000000</maxRunTime>
Expand Down