Skip to content
This repository was archived by the owner on May 8, 2024. It is now read-only.

Handling large amount of files changedΒ #13

@leonard-thieu

Description

@leonard-thieu

dt-review-tool doesn't handle large amount of files changed well (see DefinitelyTyped/DefinitelyTyped#17159 for an example). It'll only retrieve the first 30 files (the default Github limit). Handling more files is possible through options and paging but introduces another problem with API quotas. I believe dt-review-tool issues 3 requests per file (meaning over 1200 requests for the above PR).

A possible solution would be to use git to retrieve the data needed. I think this should cut it down to only 1 request per PR but introduces some complexity.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions