Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

celery work not start with sentinel redis 7.0.8 #8762

Open
1 of 3 tasks
sebglon opened this issue Sep 29, 2023 · 0 comments
Open
1 of 3 tasks

celery work not start with sentinel redis 7.0.8 #8762

sebglon opened this issue Sep 29, 2023 · 0 comments
Labels

Comments

@sebglon
Copy link
Contributor

sebglon commented Sep 29, 2023

Bug description

Deploy the latest version of defectdojoj (2.26.4)
With a redis sentinel v 7.0.8

Steps to reproduce
Steps to reproduce the behavior:

  1. Deploy defectdojo
  2. See error on defectdojo-celery-worker
[29/Sep/2023 13:15:23] INFO [celery.worker.consumer.connection:22] Connected to sentinel://redis.redis.svc.cluster.local:26379//
[29/Sep/2023 13:15:23] INFO [celery.worker.consumer.mingle:40] mingle: searching for neighbors
[29/Sep/2023 13:15:24] INFO [celery.worker.consumer.mingle:49] mingle: all alone
[29/Sep/2023 13:15:24] INFO [celery.apps.worker:175] celery@defectdojo-celery-worker-87d66745d-nksgk ready.
[29/Sep/2023 13:15:24] CRITICAL [celery.worker:206] Unrecoverable error: TypeError("SentinelManagedConnection.read_response() got an unexpected keyword argument 'push_request'")
Traceback (most recent call last):
  File "/usr/local/lib/python3.11/site-packages/celery/worker/worker.py", line 202, in start
    self.blueprint.start(self)
  File "/usr/local/lib/python3.11/site-packages/celery/bootsteps.py", line 116, in start
    step.start(parent)
  File "/usr/local/lib/python3.11/site-packages/celery/bootsteps.py", line 365, in start
    return self.obj.start()
           ^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/celery/worker/consumer/consumer.py", line 340, in start
    blueprint.start(self)
  File "/usr/local/lib/python3.11/site-packages/celery/bootsteps.py", line 116, in start
    step.start(parent)
  File "/usr/local/lib/python3.11/site-packages/celery/worker/consumer/consumer.py", line 742, in start
    c.loop(*c.loop_args())
  File "/usr/local/lib/python3.11/site-packages/celery/worker/loops.py", line 97, in asynloop
    next(loop)
  File "/usr/local/lib/python3.11/site-packages/kombu/asynchronous/hub.py", line 373, in create_loop
    cb(*cbargs)
  File "/usr/local/lib/python3.11/site-packages/kombu/transport/redis.py", line 1341, in on_readable
    self.cycle.on_readable(fileno)
  File "/usr/local/lib/python3.11/site-packages/kombu/transport/redis.py", line 566, in on_readable
    chan.handlers[type]()
  File "/usr/local/lib/python3.11/site-packages/kombu/transport/redis.py", line 910, in _receive
    ret.append(self._receive_one(c))
               ^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/kombu/transport/redis.py", line 920, in _receive_one
    response = c.parse_response()
               ^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/redis/client.py", line 796, in parse_response
    response = self._execute(conn, try_read)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/redis/client.py", line 772, in _execute
    return conn.retry.call_with_retry(
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/redis/retry.py", line 46, in call_with_retry
    return do()
           ^^^^
  File "/usr/local/lib/python3.11/site-packages/redis/client.py", line 773, in <lambda>
    lambda: command(*args, **kwargs),
            ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/redis/client.py", line 794, in try_read
    return conn.read_response(disconnect_on_error=False, push_request=True)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: SentinelManagedConnection.read_response() got an unexpected keyword argument 'push_request'

Expected behavior
defectdojo-celery-worker is not crashing

Deployment method (select with an X)

  • Docker Compose
  • Kubernetes
  • GoDojo

Environment information

  • DefectDojo version: 2.26.4

This ticket seems linked to jazzband/django-redis#678

@sebglon sebglon added the bug label Sep 29, 2023
@sebglon sebglon changed the title Failt to work with sentinel redis 7.0.8 celery work not start with sentinel redis 7.0.8 Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant