Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checklist for env vars #281

Open
raphaeltm opened this issue Dec 7, 2024 · 3 comments
Open

Checklist for env vars #281

raphaeltm opened this issue Dec 7, 2024 · 3 comments

Comments

@raphaeltm
Copy link
Collaborator

I was trying to deploy a new sample and couldn't figure out why the action was failing. Previously I've setup an action that gives you a "checklist" of stuff to do. This time I think I needed to add some config to deploy-changed-samples.yml but it's not clear. The error was:

Failed to set configs: config JUPYTER_TOKEN not found in environment

I looked in the action config and noticed that everything there was prefixed with TEST_ so I added that and it still failed, and then I realized I may have to add it manually to the action file as well, so I tried that... will see if it works.

If this is the correct workflow, a test for it should be added to the action that generates the checklist.

@raphaeltm
Copy link
Collaborator Author

@jordanstephens tagging you because I think you setup the workflow with the env vars, so if you can point me in the right direction that would be helpful

@jordanstephens
Copy link
Member

@jordanstephens tagging you because I think you setup the workflow with the env vars, so if you can point me in the right direction that would be helpful

@raphaeltm I added JUPYTER_TOKEN=jupyter-token to the environment secrets at https://github.com/DefangLabs/samples/settings/environments/4592148126/edit

@raphaeltm
Copy link
Collaborator Author

@jordanstephens okay, I think I'm misunderstanding something.

Was this necessary?
https://github.com/DefangLabs/samples/pull/280/files#diff-81b0b1359efe6c87999ed09916f9a8acbc1f236ed171ad6e5ac914449f169e9eR78

Some other samples have secrets, but don't have them listed in the settings. But it seems like they all have a version prefixed with TEST_.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants