Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some loadtest samples are misconfigured #273

Open
acote88 opened this issue Nov 26, 2024 · 0 comments
Open

Some loadtest samples are misconfigured #273

acote88 opened this issue Nov 26, 2024 · 0 comments
Assignees
Milestone

Comments

@acote88
Copy link

acote88 commented Nov 26, 2024

We run a daily loadtest which deploys each sample to staging. This test is only really useful if it is passing most of the time. That's the only way we will notice new failures.

To help us get more signal than noise, let's do the following:

  1. Reduce the number of samples deployed every day.
    • Ideally we should pick a handful of the most complex samples so that we exercise more of the system. This list will change over time.
    • This will serve as a sanity check for the platform. We will move sample testing to the samples repo.
  2. Avoid loading configuration from workflow secrets. Maybe hardcode them in a yaml file? These aren't truly sensitive secret values, so we can safely handle them with less care.
  3. Partition the configuration by sample name: The list of configuration values is currently flat, so we don't know which configuration values are relevant to which sample. Scoping each configuration list by sample name would be a helpful improvement.
  4. Create a github actions workflow in the DefangLabs/samples repo which will test a sample when it is changed in a PR.
    • Evaluate the PR diff to detect which samples have been modified
    • For each modified sample, run the following test:
      • Make sure we can start the containers locally with docker compose up.
      • Make sure we can deploy to defang with defang compose up.

Here are the samples I think are failing because of misconfiguration:

bullmq-bullboard-redis
django-postgres
fastapi-postgres
golang-mongodb-atlas
hasura
huginn
langchain
metabase
nextjs-postgres
nocodb
nodejs-react-postgres
phoenix-postgres
python-implicit-gpu
rails
sailsjs-postgres
vllm

Footnotes:

@acote88 acote88 added this to the V2 milestone Nov 26, 2024
@Prakash-Sundaresan Prakash-Sundaresan modified the milestones: V2, Jan2025 Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants