Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing fabricDNS might delete services after creating them #27

Open
lionello opened this issue Apr 23, 2024 · 0 comments
Open

Changing fabricDNS might delete services after creating them #27

lionello opened this issue Apr 23, 2024 · 0 comments
Labels
bug Something isn't working
Milestone

Comments

@lionello
Copy link
Member

lionello commented Apr 23, 2024

If the new fabricDNS resolves to the same URL as the old one (for example, one has implied tenant, other has explicit tenant), then the services will be deleted after being created/updated.

The solution is to make sure we normalize the fabricDNS before we compare the old and new and decided whether to replace the resource.

https://github.com/defang-io/pulumi-defang/blob/f1c6e974d40cd6f4d4d1845324d0127f1cedf932/index.ts#L597

This only affects us (Portal)

@lionello lionello added the bug Something isn't working label Apr 23, 2024
@nullfunc nullfunc added this to the Sep2024-V1 milestone Jul 3, 2024
@lionello lionello removed this from the Sep2024 milestone Sep 26, 2024
@lionello lionello added this to the V2 milestone Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants