Skip to content

Fix Starlette TemplateResponse deprecation in web UI routes #37

@iamh2o

Description

@iamh2o

Summary

tests/test_web_server.py still emits Starlette TemplateResponse(...) deprecation warnings after the FastAPI lifecycle on_event migration.

The current warning is:

The name is not the first parameter anymore. The first parameter should be the Request instance.
Replace TemplateResponse(name, {"request": request}) by TemplateResponse(request, name).

Repro

From the repo root:

source ./zday_activate
pytest -q -W "error:.*on_event.*:DeprecationWarning" tests/test_web_server.py

That run now passes the on_event lifecycle check, but still reports Starlette TemplateResponse deprecations from the UI router.

Affected code

Current request-old-signature call sites are in zebra_day/web/routers/ui.py, including:

  • zebra_day/web/routers/ui.py:209
  • zebra_day/web/routers/ui.py:231
  • zebra_day/web/routers/ui.py:341
  • zebra_day/web/routers/ui.py:422
  • zebra_day/web/routers/ui.py:453
  • zebra_day/web/routers/ui.py:474
  • zebra_day/web/routers/ui.py:522
  • zebra_day/web/routers/ui.py:599
  • zebra_day/web/routers/ui.py:619
  • zebra_day/web/routers/ui.py:640
  • zebra_day/web/routers/ui.py:686
  • zebra_day/web/routers/ui.py:703
  • zebra_day/web/routers/ui.py:916
  • zebra_day/web/routers/ui.py:960

Expected fix

Update the Zebra Day template responses to the current Starlette/FastAPI request-first signature so these warnings go away on current dependencies.

Acceptance

  • tests/test_web_server.py passes without Starlette TemplateResponse deprecation warnings.
  • Zebra Day remains compatible with the current FastAPI/Starlette stack.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions