Skip to content

Commit 0149b8c

Browse files
committed
Fix bug
1 parent f34a5b4 commit 0149b8c

File tree

8 files changed

+32
-27
lines changed

8 files changed

+32
-27
lines changed

Cargo.lock

Lines changed: 7 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Cargo.toml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,11 +16,11 @@ members = [
1616
#pydf_io = { path = "../maplib/lib/pydf_io"}
1717
#representation = { path = "../maplib/lib/representation", features = ["rdf-star"]}
1818
#templates = { path = "../maplib/lib/templates"}
19-
spargebra = { git = "https://github.com/DataTreehouse/maplib", rev="02df7b582260fa728807fc3cef50ce8c8af690b6" }
20-
query_processing = { git = "https://github.com/DataTreehouse/maplib", rev="02df7b582260fa728807fc3cef50ce8c8af690b6" }
21-
pydf_io = { git = "https://github.com/DataTreehouse/maplib", rev="02df7b582260fa728807fc3cef50ce8c8af690b6" }
22-
representation = { git = "https://github.com/DataTreehouse/maplib", rev="02df7b582260fa728807fc3cef50ce8c8af690b6" }
23-
templates = { git = "https://github.com/DataTreehouse/maplib", rev="02df7b582260fa728807fc3cef50ce8c8af690b6" }
19+
spargebra = { git = "https://github.com/DataTreehouse/maplib", rev="ec762caed6894a63f06943cac5c64cc8d8153a10" }
20+
query_processing = { git = "https://github.com/DataTreehouse/maplib", rev="ec762caed6894a63f06943cac5c64cc8d8153a10" }
21+
pydf_io = { git = "https://github.com/DataTreehouse/maplib", rev="ec762caed6894a63f06943cac5c64cc8d8153a10" }
22+
representation = { git = "https://github.com/DataTreehouse/maplib", rev="ec762caed6894a63f06943cac5c64cc8d8153a10" }
23+
templates = { git = "https://github.com/DataTreehouse/maplib", rev="ec762caed6894a63f06943cac5c64cc8d8153a10" }
2424

2525

2626
sparesults = { version = "0.2.3" }

lib/chrontext/src/rewriting/graph_patterns.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
mod bgp_pattern;
1+
mod bg_pattern;
22
mod distinct_pattern;
33
mod extend_pattern;
44
mod filter_pattern;

lib/chrontext/src/rewriting/graph_patterns/bgp_pattern.rs renamed to lib/chrontext/src/rewriting/graph_patterns/bg_pattern.rs

File renamed without changes.

lib/virtualized_query/src/lib.rs

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -209,10 +209,14 @@ impl BasicVirtualizedQuery {
209209
fn expected_columns(&self) -> HashSet<&str> {
210210
let mut s = HashSet::new();
211211
for tp in self.column_mapping.values() {
212-
if let TermPattern::Variable(v) = tp {
213-
s.insert(v.as_str());
214-
} else {
215-
todo!()
212+
match tp {
213+
TermPattern::BlankNode(b) => todo!("For the time being, replace {} with a variable", b),
214+
TermPattern::Literal(_) | TermPattern::NamedNode(_) => {
215+
//No action required
216+
}
217+
TermPattern::Variable(v) => {
218+
s.insert(v.as_str());
219+
}
216220
}
217221
}
218222
if let Some(grouping_var) = &self.grouping_col {

py_chrontext/pyproject.toml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@ dependencies = ["polars>=0.20.2",
55
"pyarrow>=7.0.0",
66
"pandas",
77
"sqlalchemy>=2.0.31",
8-
"sqlalchemy_bigquery==1.11.0",
9-
"databricks-sqlalchemy==2.0.4",
8+
"sqlalchemy-bigquery>=1.11.0",
9+
"databricks-sqlalchemy>=2.0.4",
1010
"databricks-sql-connector>=3.3.0",
1111
"pyoxigraph>=0.4.2"]
1212
readme = "README.md"
Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
python-dotenv==1.0.0
2-
pytest==7.4.2
3-
pytest-order==1.2.0
4-
docker==7.1.0
1+
python-dotenv>=1.0.0
2+
pytest>=7.4.2
3+
pytest-order>=1.2.0
4+
docker>=7.1.0
55
requests>=2.32.0
6-
sparqlwrapper==2.0.0
7-
asyncua==1.0.4
6+
sparqlwrapper>=2.0.0
7+
asyncua>=1.0.4
88
duckdb>=1.0.0

py_chrontext/tests/test_python_database.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -249,7 +249,7 @@ def test_pushdown_group_by_second_having_hybrid_query(engine):
249249
df = sm.mappings.cast({"sum_v": pl.Int64}).sort(by)
250250
expected = pl.read_csv(TESTDATA_PATH / "expected_pushdown_group_by_second_having_hybrid.csv", try_parse_dates=True).sort(by)
251251
assert_frame_equal(df, expected)
252-
assert sm.pushdown_paths == [['ProjectInner', 'FilterInner', 'ExtendInner', 'ExtendInner']]
252+
assert sm.pushdown_paths == [['ProjectInner', 'ExtendInner', 'ExtendInner', 'FilterInner']]
253253

254254

255255
def test_union_of_two_groupby_queries(engine):
@@ -300,8 +300,8 @@ def test_union_of_two_groupby_queries(engine):
300300
assert sm.pushdown_paths == [['ProjectInner',
301301
'UnionLeftSide',
302302
'ProjectInner',
303-
'FilterInner',
304303
'ExtendInner',
304+
'FilterInner',
305305
'GroupInner',
306306
'FilterInner',
307307
'ExtendInner',
@@ -310,8 +310,8 @@ def test_union_of_two_groupby_queries(engine):
310310
['ProjectInner',
311311
'UnionRightSide',
312312
'ProjectInner',
313-
'FilterInner',
314313
'ExtendInner',
314+
'FilterInner',
315315
'GroupInner',
316316
'FilterInner',
317317
'ExtendInner',

0 commit comments

Comments
 (0)