Merge branch '6.0' into 6.0-fix-nuget-readme

Author: alex-kulakov

ChangeLog/6.0.13_dev.txt

@@ -0,0 +1,7 @@
+[main] Fixed certain cases of bad translation of casts via 'as' operator in LINQ queries
+[main] Addressed certain issues of translation connected with comparison with local entity instace within LINQ queries
+[main] Fixed rare issues of incorrect translation of filtered index expressions including conditional expressions
+[main] Join/LeftJoin is denied to have the same expression instance for both inner/outer selector
+[main] Addressed issue when wrong type of join was chosen when .First/FirstOrDefalult() method was used as subquery
+[main] Added dedicated exception when RenameFieldHint.TargetType exists in current model but absent in storage model
+[postgresql] Fixed issue of incorrect translation of contitional expressions including comparison with nullable fields

Directory.Build.props

@@ -40,6 +40,7 @@
     <ProjectAssetsFile>$(MSBuildProjectExtensionsPath)project.assets.json</ProjectAssetsFile>
     <ProjectAssetsCacheFile>$(MSBuildProjectExtensionsPath)$(MSBuildProjectName).assets.cache</ProjectAssetsCacheFile>
     <OrmKeyFile>$(SolutionDir)Orm\Orm.snk</OrmKeyFile>
+	<NoWarn>$(NoWarn);NETSDK1138</NoWarn>
   </PropertyGroup>
 
   <PropertyGroup>

Extensions/Xtensive.Orm.Logging.NLog/Log.cs

@@ -1,6 +1,6 @@
-// Copyright (C) 2003-2013 Xtensive LLC.
-// All rights reserved.
-// For conditions of distribution and use, see license.
+// Copyright (C) 2013-2023 Xtensive LLC.
+// This code is distributed under MIT license terms.
+// See the License.txt file in the project root for more information.
 // Created by: Dmitri Maximov
 // Created:    2013.12.13
 
@@ -10,6 +10,9 @@
 
 namespace Xtensive.Orm.Logging.NLog
 {
+  /// <summary>
+  /// Log implementation for NLog.
+  /// </summary>
   public class Log : BaseLog
   {
     private readonly Logger target;
@@ -30,11 +33,13 @@ private static NLogLevel ConvertLevel(LogLevel level)
       }
     }
 
+    /// <inheritdoc/>
     public override bool IsLogged(LogLevel level)
     {
       return target.IsEnabled(ConvertLevel(level));
     }
 
+    /// <inheritdoc/>
     public override void Write(LogEventInfo info)
     {
       if (info.Exception!=null)
@@ -43,6 +48,10 @@ public override void Write(LogEventInfo info)
         target.Log(ConvertLevel(info.Level), info.FormattedMessage);
     }
 
+    /// <summary>
+    /// Creates instance of <see cref="Log"/> class.
+    /// </summary>
+    /// <param name="name">Log name.</param>
     public Log(string name)
     {
       target = NLogManager.GetLogger(name);

Extensions/Xtensive.Orm.Logging.NLog/LogProvider.cs

@@ -1,13 +1,17 @@
-// Copyright (C) 2003-2013 Xtensive LLC.
-// All rights reserved.
-// For conditions of distribution and use, see license.
+// Copyright (C) 2013-2023 Xtensive LLC.
+// This code is distributed under MIT license terms.
+// See the License.txt file in the project root for more information.
 // Created by: Dmitri Maximov
 // Created:    2013.12.13
 
 namespace Xtensive.Orm.Logging.NLog
 {
+  /// <summary>
+  /// Provides NLog specific <see cref="BaseLog"/> descendant instances.
+  /// </summary>
   public class LogProvider : Logging.LogProvider
   {
+    /// <inheritdoc />
     public override BaseLog GetLog(string logName)
     {
       return new Log(logName);

Extensions/Xtensive.Orm.Logging.log4net/Log.cs

@@ -1,6 +1,6 @@
-// Copyright (C) 2014 Xtensive LLC.
-// All rights reserved.
-// For conditions of distribution and use, see license.
+// Copyright (C) 2014-2023 Xtensive LLC.
+// This code is distributed under MIT license terms.
+// See the License.txt file in the project root for more information.
 // Created by: Alexey Kulakov
 // Created:    2014.02.20
 
@@ -11,6 +11,9 @@
 
 namespace Xtensive.Orm.Logging.log4net
 {
+  /// <summary>
+  /// Log implementation for log4net.
+  /// </summary>
   public class Log : BaseLog
   {
     private log4netLog target;
@@ -32,16 +35,25 @@ private Level ConvertLevel(LogLevel level)
         return Level.Info;
       }
     }
+
+    /// <inheritdoc />
     public override bool IsLogged(LogLevel level)
     {
       return target.Logger.IsEnabledFor(ConvertLevel(level));
     }
 
+    /// <inheritdoc />
     public override void Write(LogEventInfo info)
     {
       target.Logger.Log(target.Logger.GetType(), ConvertLevel(info.Level), info.FormattedMessage, info.Exception);
     }
 
+    /// <summary>
+    /// Creates instance of <see cref="Log"/> class.
+    /// </summary>
+    /// <param name="repositoryAssembly">An <see cref="Assembly"/> instance this <see cref="Log"/> instance
+    /// is related to.</param>
+    /// <param name="name">Log name.</param>
     public Log(Assembly repositoryAssembly, string name)
     {
       target = log4netLogManager.GetLogger(repositoryAssembly, name);

Extensions/Xtensive.Orm.Logging.log4net/LogProvider.cs

@@ -1,6 +1,6 @@
-// Copyright (C) 2014 Xtensive LLC.
-// All rights reserved.
-// For conditions of distribution and use, see license.
+// Copyright (C) 2014-2023 Xtensive LLC.
+// This code is distributed under MIT license terms.
+// See the License.txt file in the project root for more information.
 // Created by: Alexey Kulakov
 // Created:    2014.02.20
 
@@ -9,8 +9,12 @@
 
 namespace Xtensive.Orm.Logging.log4net
 {
+  /// <summary>
+  /// Provides log4net specific <see cref="BaseLog"/> descendant instances.
+  /// </summary>
   public class LogProvider : Logging.LogProvider
   {
+    /// <inheritdoc />
     public override BaseLog GetLog(string logName)
     {
       return new Log(Assembly.GetCallingAssembly(), logName);

Extensions/Xtensive.Orm.Tracking/Interfaces/ITrackingItem.cs

@@ -1,16 +1,37 @@
+// Copyright (C) 2019-2023 Xtensive LLC.
+// This code is distributed under MIT license terms.
+// See the License.txt file in the project root for more information.
+
 using System.Collections.Generic;
 using Xtensive.Tuples;
 
 namespace Xtensive.Orm.Tracking
 {
+  /// <summary>
+  /// Represents changes happened to an <see cref="Entity"/>.
+  /// </summary>
   public interface ITrackingItem
   {
+    /// <summary>
+    /// Gets <see cref="Entity"/> key.
+    /// </summary>
     Key Key { get; }
 
+    /// <summary>
+    /// Gets raw <see cref="Entity"/> data as <see cref="DifferentialTuple"/>.
+    /// </summary>
     DifferentialTuple RawData { get; }
 
+    /// <summary>
+    /// Gets a state of a tracked <see cref="Entity"/>.
+    /// It might be <see cref="TrackingItemState.Created"/> or <see cref="TrackingItemState.Changed"/>
+    /// or <see cref="TrackingItemState.Deleted"/>.
+    /// </summary>
     TrackingItemState State { get; }
 
+    /// <summary>
+    /// Gets list of detected changes of field values.
+    /// </summary>
     IList<ChangedValue> ChangedValues { get; }
   }
 }

Extensions/Xtensive.Orm.Tracking/Internals/SessionTrackingMonitor.cs

@@ -1,4 +1,8 @@
-using System;
+// Copyright (C) 2019-2023 Xtensive LLC.
+// This code is distributed under MIT license terms.
+// See the License.txt file in the project root for more information.
+
+using System;
 using System.Collections.Generic;
 using System.Linq;
 using Xtensive.IoC;
@@ -65,17 +69,15 @@ private void OnPersisting(object sender, EventArgs e)
     /// </summary>
     /// <param name="session"><see cref="T:Xtensive.Orm.Session"/>, to which current instance
     /// is bound.</param>
+    /// <param name="accessor"><see cref="DirectSessionAccessor"/> instance to get access to
+    /// changed entities of each kind. See <see cref="DirectSessionAccessor.GetChangedEntities"/> method
+    /// for reference.</param>
     /// <exception cref="T:System.ArgumentNullException"><paramref name="session"/> is <see langword="null"/>.</exception>
     [ServiceConstructor]
     public SessionTrackingMonitor(Session session, DirectSessionAccessor accessor)
     {
-      if (session==null)
-        throw new ArgumentNullException("session");
-      if (accessor==null)
-        throw new ArgumentNullException("accessor");
-
-      this.session = session;
-      this.accessor = accessor;
+      this.session = session ?? throw new ArgumentNullException(nameof(session));
+this.accessor = accessor ?? throw new ArgumentNullException(nameof(accessor));
 
       stack = new Stack<TrackingStackFrame>();
       stack.Push(new TrackingStackFrame());

Extensions/Xtensive.Orm.Tracking/TrackingCompletedEventArgs.cs

@@ -1,4 +1,4 @@
-using System;
+using System;
 using System.Collections.Generic;
 
 namespace Xtensive.Orm.Tracking
@@ -21,16 +21,13 @@ public sealed class TrackingCompletedEventArgs : EventArgs
     /// <summary>
     /// Initializes a new instance of the <see cref="TrackingCompletedEventArgs"/> class.
     /// </summary>
+    /// <param name="session"><see cref="T:Session"/> instance where the <see cref="Changes"/>
+    /// where collected.</param>
     /// <param name="changes">The changes.</param>
     public TrackingCompletedEventArgs(Session session, IEnumerable<ITrackingItem> changes)
     {
-      if (session==null)
-        throw new ArgumentNullException("session");
-      if (changes == null)
-        throw new ArgumentNullException("changes");
-
-      Session = session;
-      Changes = changes;
+      Session = session ?? throw new ArgumentNullException("session");
+      Changes = changes ?? throw new ArgumentNullException("changes");
     }
   }
 }

Extensions/Xtensive.Orm.Web/AplicationBuilderExtensions.cs

@@ -1,9 +1,12 @@
-using System;
+using System;
 using Xtensive.Core;
 using Microsoft.AspNetCore.Builder;
 
 namespace Xtensive.Orm.Web
 {
+  /// <summary>
+  /// Extensions for <see cref="IApplicationBuilder"/>
+  /// </summary>
   public static class AplicationBuilderExtensions
   {
     /// <summary>