HintSet.HasHints method improvement

alex-kulakov · AlexUstinov · web-flow · commit 941066efed8a · 2021-03-18T21:33:22.000+05:00
Co-authored-by: Aleksandr Ustinov &lt;alex.ustinov@servicetitan.com&gt;
diff --git a/Orm/Xtensive.Orm/Modelling/Comparison/Hints/HintSet.cs b/Orm/Xtensive.Orm/Modelling/Comparison/Hints/HintSet.cs
@@ -193,11 +193,9 @@ public bool HasHints<THint>(Node node)
     {
       ArgumentValidator.EnsureArgumentNotNull(node, "node");
 
-      if (!hintMap.ContainsKey(node))
-        hintMap.Add(node, new Dictionary<Type, object>());
-      var nodeHintMap = hintMap.GetValueOrDefault(node);
-      if (nodeHintMap == null)
-        return false;
+      if (!hintMap.TryGetValue(node, out var nodeHintMap)) {
+        hintMap.Add(node, nodeHintMap = new Dictionary<Type, object>());
+      }
       return nodeHintMap.ContainsKey(typeof(THint));
     }
 
@@ -260,4 +258,4 @@ private HintSet()
     {
     }
   }
-}
+}

Original file line number	Diff line number	Diff line change
`@@ -193,11 +193,9 @@ public bool HasHints<THint>(Node node)`
`193`	`193`	`{`
`194`	`194`	`ArgumentValidator.EnsureArgumentNotNull(node, "node");`
`195`	`195`
`196`		`- if (!hintMap.ContainsKey(node))`
`197`		`- hintMap.Add(node, new Dictionary<Type, object>());`
`198`		`- var nodeHintMap = hintMap.GetValueOrDefault(node);`
`199`		`- if (nodeHintMap == null)`
`200`		`- return false;`
	`196`	`+ if (!hintMap.TryGetValue(node, out var nodeHintMap)) {`
	`197`	`+ hintMap.Add(node, nodeHintMap = new Dictionary<Type, object>());`
	`198`	`+ }`
`201`	`199`	`return nodeHintMap.ContainsKey(typeof(THint));`
`202`	`200`	`}`
`203`	`201`
`@@ -260,4 +258,4 @@ private HintSet()`
`260`	`258`	`{`
`261`	`259`	`}`
`262`	`260`	`}`
`263`		`-}`
	`261`	`+}`