Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New class hierarchy #25

Open
grzanka opened this issue Feb 9, 2016 · 0 comments
Open

New class hierarchy #25

grzanka opened this issue Feb 9, 2016 · 0 comments

Comments

@grzanka
Copy link
Collaborator

grzanka commented Feb 9, 2016

Current class hierarchy comes from analysis of proton beams. I think we can easily get rid of some of the classes and move some of them (i.e. LateralProfile, DistalProfile) to user code: examples etc...
We need a clear separation of responsibilty between various classes. At the beginning I would start with two:

  1. Curve - general class to represent set of (x,y) pairs where x coordinates is in ascending order
  2. Profile - subclass of Curve, for which y coordinates are first more-less increase and them more-less descrease
    For Profile it might sense to calculate width, fwhm and other features based on rising-falling character, which for Curve - not.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants