chore(bin-tests): use builder

Author: hoolioh

bin_tests/src/bin/crashing_test_app.rs

@@ -18,7 +18,7 @@ mod unix {
     use std::sync::Arc;
     use std::time::Duration;
 
-    use libdd_common::{tag, Endpoint};
+    use libdd_common::tag;
     use libdd_crashtracker::{
         self as crashtracker, CrashtrackerConfiguration, CrashtrackerReceiverConfig, Metadata,
     };
@@ -91,19 +91,17 @@ mod unix {
         let stdout_filename = format!("{output_dir}/out.stdout");
 
         ensure!(!output_url.is_empty(), "output_url must not be empty");
-        let endpoint = Some(Endpoint::from_slice(&output_url));
-
-        let config = CrashtrackerConfiguration::new(
-            vec![], // additional_files
-            true,   // create_alt_stack
-            true,   // use_alt_stack
-            endpoint,
-            crashtracker::StacktraceCollection::EnabledWithSymbolsInReceiver,
-            crashtracker::default_signals(),
-            Some(TEST_COLLECTOR_TIMEOUT),
-            Some("".to_string()), // unix_socket_path
-            true,                 // demangle_names
-        )?;
+
+        let config = CrashtrackerConfiguration::builder()
+            .create_alt_stack(true)
+            .use_alt_stack(true)
+            .endpoint_url(&output_url)
+            .resolve_frames(crashtracker::StacktraceCollection::EnabledWithSymbolsInReceiver)
+            .signals(crashtracker::default_signals())
+            .timeout(TEST_COLLECTOR_TIMEOUT)
+            .unix_socket_path("".to_string())
+            .demangle_names(true)
+            .build()?;
 
         let metadata = Metadata {
             library_name: "libdatadog".to_owned(),

bin_tests/src/bin/crashtracker_bin_test.rs

@@ -22,7 +22,7 @@ mod unix {
     use std::process;
     use std::time::Duration;
 
-    use libdd_common::{tag, Endpoint};
+    use libdd_common::tag;
     use libdd_crashtracker::{
         self as crashtracker, CrashtrackerConfiguration, CrashtrackerReceiverConfig, Metadata,
         StackFrame, StackTrace,
@@ -73,12 +73,6 @@ mod unix {
         let stdout_filename = format!("{output_dir}/out.stdout");
         let output_dir: &Path = output_dir.as_ref();
 
-        let endpoint = if output_url.is_empty() {
-            None
-        } else {
-            Some(Endpoint::from_slice(output_url))
-        };
-
         // The configuration can be modified by a Behavior (testing plan), so it is mut here.
         // Unlike a normal harness, in this harness tests are run in individual processes, so race
         // issues are avoided.
@@ -97,17 +91,16 @@ mod unix {
             Err(_) => crashtracker::StacktraceCollection::WithoutSymbols,
         };
 
-        let mut config = CrashtrackerConfiguration::new(
-            vec![],
-            true,
-            true,
-            endpoint,
-            stacktrace_collection,
-            crashtracker::default_signals(),
-            Some(TEST_COLLECTOR_TIMEOUT),
-            Some("".to_string()),
-            true,
-        )?;
+        let mut config = CrashtrackerConfiguration::builder()
+            .create_alt_stack(true)
+            .demangle_names(true)
+            .endpoint_url(output_url)
+            .resolve_frames(stacktrace_collection)
+            .signals(crashtracker::default_signals())
+            .timeout(TEST_COLLECTOR_TIMEOUT)
+            .unix_socket_path("".to_string())
+            .use_alt_stack(true)
+            .build()?;
 
         let metadata = Metadata {
             library_name: "libdatadog".to_owned(),

bin_tests/tests/crashtracker_bin_test.rs

@@ -1331,23 +1331,23 @@ fn crash_tracking_empty_endpoint() {
 #[cfg_attr(miri, ignore)]
 #[cfg(unix)]
 fn test_receiver_emits_debug_logs_on_receiver_issue() -> anyhow::Result<()> {
+    use std::time::Duration;
+
     let receiver = artifacts::crashtracker_receiver(BuildProfile::Debug);
     let artifacts = build_artifacts(&[&receiver])?;
     let fixtures = bin_tests::test_runner::TestFixtures::new()?;
 
     let missing_file = fixtures.output_dir.join("missing_additional_file.txt");
 
-    let config = CrashtrackerConfiguration::new(
-        vec![missing_file.display().to_string()],
-        true,
-        true,
-        None,
-        StacktraceCollection::WithoutSymbols,
-        libdd_crashtracker::default_signals(),
-        Some(std::time::Duration::from_millis(500)),
-        None,
-        true,
-    )?;
+    let config = CrashtrackerConfiguration::builder()
+        .additional_files(vec![missing_file.display().to_string()])
+        .create_alt_stack(true)
+        .demangle_names(true)
+        .resolve_frames(StacktraceCollection::WithoutSymbols)
+        .signals(libdd_crashtracker::default_signals())
+        .timeout(Duration::from_millis(500))
+        .use_alt_stack(true)
+        .build()?;
 
     let metadata = Metadata {
         library_name: "libdatadog".to_owned(),