fix pool callback context

rochdev · rochdev · commit a68ab8621ca1 · 2025-05-29T12:28:09.000-04:00
diff --git a/packages/datadog-instrumentations/src/mysql.js b/packages/datadog-instrumentations/src/mysql.js
@@ -80,8 +80,7 @@ addHook({ name: 'mysql', file: 'lib/Pool.js', versions: ['>=2'] }, Pool => {
       const cb = arguments[arguments.length - 1]
       if (typeof cb === 'function') {
         arguments[arguments.length - 1] = shimmer.wrapFunction(cb, cb => function () {
-          finish()
-          return cb.apply(this, arguments)
+          return finishPoolQueryCh.runStores(ctx, cb, this, arguments)
         })
       }
 

Original file line number	Diff line number	Diff line change
`@@ -80,8 +80,7 @@ addHook({ name: 'mysql', file: 'lib/Pool.js', versions: ['>=2'] }, Pool => {`
`80`	`80`	`const cb = arguments[arguments.length - 1]`
`81`	`81`	`if (typeof cb === 'function') {`
`82`	`82`	`arguments[arguments.length - 1] = shimmer.wrapFunction(cb, cb => function () {`
`83`		`- finish()`
`84`		`- return cb.apply(this, arguments)`
	`83`	`+ return finishPoolQueryCh.runStores(ctx, cb, this, arguments)`
`85`	`84`	`})`
`86`	`85`	`}`
`87`	`86`