You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
What Does This Do
The main fix is that test 4 now waits for its two traces before finishing. This prevents those traces from leaking into test 5. With that in place
Motivation
test security_response_id is not present in trace when request is not blocked is flaky on master
Copy file name to clipboardExpand all lines: dd-smoke-tests/appsec/springboot/src/test/groovy/datadog/smoketest/appsec/SecurityResponseIdSmokeTest.groovy
+9-5Lines changed: 9 additions & 5 deletions
Original file line number
Diff line number
Diff line change
@@ -241,6 +241,9 @@ class SecurityResponseIdSmokeTest extends AbstractAppSecServerSmokeTest {
241
241
242
242
// Verify security_response_id was NOT added to the URL
243
243
assert!location.contains('security_response_id'), "security_response_id should not be added when placeholder is not present: ${location}"
244
+
245
+
and: 'wait for the trace to be collected'
246
+
waitForTraceCount(1) ==1
244
247
}
245
248
246
249
void'test security_response_id format is consistent across requests'() {
@@ -284,6 +287,9 @@ class SecurityResponseIdSmokeTest extends AbstractAppSecServerSmokeTest {
assert normalSpan !=null, "Root span for /custom-headers endpoint not found in trace. Available spans: ${spans.collect { it.meta?.get('http.route') }}"
320
+
rootSpans.size() ==1
321
+
def normalSpan = rootSpans.first()
318
322
319
323
// When the request is not blocked, there should be no triggers at all
0 commit comments